Skip to content

Stabilize complex attributes #7973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
trask wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Stabilize complex attributes #7973

trask wants to merge 20 commits into from

Conversation

@trask
Copy link
Member

@trask trask commented Jan 9, 2026

No description provided.

@trask trask force-pushed the stabilize-complex-attributes-try-2 branch from 3bc8e76 to 8c951bd Compare January 9, 2026 22:32
@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.76562% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (62049e7) to head (d31abc4).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/io/opentelemetry/api/common/ProtoJson.java 73.61% 15 Missing and 4 partials ⚠️
...metry/api/common/ArrayBackedAttributesBuilder.java 90.16% 2 Missing and 4 partials ⚠️
...c/main/java/io/opentelemetry/api/common/Empty.java 0.00% 5 Missing ⚠️
...pentelemetry/api/common/ArrayBackedAttributes.java 92.85% 2 Missing and 2 partials ⚠️
...n/java/io/opentelemetry/api/common/ValueEmpty.java 62.50% 3 Missing ⚠️
...lemetry/exporter/zipkin/EventDataToAnnotation.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7973      +/-   ##
============================================
+ Coverage     90.15%   90.19%   +0.03%     
- Complexity     7476     7594     +118     
============================================
  Files           836      837       +1     
  Lines         22550    22771     +221     
  Branches       2224     2270      +46     
============================================
+ Hits          20331    20538     +207     
- Misses         1515     1520       +5     
- Partials        704      713       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask force-pushed the stabilize-complex-attributes-try-2 branch from 30fb180 to 0e2af07 Compare January 9, 2026 23:37
@trask trask force-pushed the stabilize-complex-attributes-try-2 branch 4 times, most recently from 55d9121 to 23f5d22 Compare January 10, 2026 04:05
@trask trask force-pushed the stabilize-complex-attributes-try-2 branch from 23f5d22 to 0e19885 Compare January 10, 2026 04:15
trask
trask commented Jan 10, 2026
View reviewed changes
api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributes.java
Copy link
Member Author

@trask trask Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes copy-pasted from ExtendedArrayBackedAttributes.java

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributesBuilder.java
Copy link
Member Author

@trask trask Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes copy-pasted from ExtendedArrayBackedAttributesBuilder.java

api/all/src/main/java/io/opentelemetry/api/common/AttributeKey.java
Copy link
Member Author

@trask trask Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes copy-pasted from ExtendedAttributeKey.java

api/all/src/main/java/io/opentelemetry/api/common/Attributes.java
Copy link
Member Author

@trask trask Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes copy-pasted from ExtendedAttributes.java

api/all/src/main/java/io/opentelemetry/api/common/AttributesBuilder.java
Copy link
Member Author

@trask trask Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes copy-pasted from ExtendedAttributesBuilder.java

Copy link
Member

@jack-berg jack-berg Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your plan to keeep ExtendedAttributes around for a couple of releases to give folks a chance to migrate gracefully?

Copy link
Member Author

@trask trask Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good point, deprecated them in c133eea

Copy link
Member Author

@trask trask Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, that spun out of control due to suppressing usages, reverted, I'd suggest that I do that as a follow-up PR

Copy link
Member Author

@trask trask Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this discussion open so I don't forget

@trask trask marked this pull request as ready for review January 10, 2026 04:16
@trask trask requested a review from a team as a code owner January 10, 2026 04:16
@trask trask force-pushed the stabilize-complex-attributes-try-2 branch from 7dabd12 to 2a8fd46 Compare January 21, 2026 23:30
@trask trask force-pushed the stabilize-complex-attributes-try-2 branch from 9f18eb0 to a98199a Compare January 22, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jack-berg jack-berg jack-berg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trask @jack-berg