fix(youtube): isolate player instances and fix multiple bugs #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined commits: - fix(plausible): use consistent window reference in clientInit stub
- Fix #339: clicking one player no longer loads all iframes - Fix #297: guard against stale refs during layout transitions - Fix #561: revert objectFit to cover, add placeholderObjectFit prop - Add player cleanup on unmount to prevent memory leaks - Fix duplicate head link keys - Add missing api-change emit - Add e2e test for multiple players Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #339, Resolves #297, Resolves #561
❓ Type of change
📚 Description
Multiple YouTube players on a page shared state incorrectly - clicking one would load ALL iframes. The component also had memory leaks (no cleanup on unmount) and layout transitions could cause playback failures.
Fixed by tracking each player's trigger state independently, adding proper cleanup via
player.destroy(), and guarding against stale refs during async operations. Also revertedobjectFitdefault fromcontainback tocoverand made it configurable via newplaceholderObjectFitprop.