feat: create release schedule component #8529

araujogui · 2026-01-09T00:55:21Z

Description

Create new release schedule component

Validation

Related Issues

Fixes #8101

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run pnpm format to ensure the code follows the style guide.
I have run pnpm test to check if all tests are passing.
I have run pnpm build to check if the website builds without errors.
I've covered new added functionality with unit tests if necessary.

vercel · 2026-01-09T00:55:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
nodejs-org	Ready	Preview	Jan 16, 2026 3:19pm

github-actions · 2026-01-09T00:55:32Z

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

araujogui · 2026-01-09T00:56:25Z

apps/site/package.json

    "feed": "~5.1.0",
    "github-slugger": "~2.0.0",
    "gray-matter": "~4.0.3",
+    "lts": "github:araujogui/lts-schedule#refactor-website",


We can use the upstream package once this pr is merged

Adding blocked until then

codecov · 2026-01-09T00:57:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.98%. Comparing base (8c5a7dd) to head (e732e4d).
⚠️ Report is 22 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8529      +/-   ##
==========================================
+ Coverage   74.70%   74.98%   +0.27%     
==========================================
  Files         102      103       +1     
  Lines        8956     9042      +86     
  Branches      305      312       +7     
==========================================
+ Hits         6691     6780      +89     
+ Misses       2263     2260       -3     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

araujogui · 2026-01-09T00:57:17Z

apps/site/components/Releases/ReleaseSchedule/index.tsx

+  const sixMonthsFromNow = new Date();
+  sixMonthsFromNow.setMonth(now.getMonth() + 6);
+
+  const svg = create({


This is showing a warning that I'm not sure how to solve:

@node-core/website:dev: Package jsdom can't be external @node-core/website:dev: The request jsdom matches serverExternalPackages (or the default list). @node-core/website:dev: The package resolves to a different version when requested from the project directory (27.4.0) compared to the package requested from the importing module (9.4.1). @node-core/website:dev: Make sure to install the same version of the package in both locations.

Copilot

Pull request overview

This PR replaces the static SVG image of the Node.js release schedule with a dynamically generated component that fetches schedule data from GitHub and renders it using the lts library.

Key Changes:

Adds a new ReleaseSchedule React component that dynamically generates the schedule visualization
Introduces a data provider to fetch release schedule JSON from the Node.js Release repository
Replaces the static image reference in the MDX file with the new component

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Adds lts package from GitHub repository along with its dependencies (d3, jsdom, svg2png, etc.)
apps/site/package.json	Declares the lts dependency from GitHub repository
apps/site/next.constants.mjs	Adds RELEASE_SCHEDULE_URL constant pointing to schedule.json
apps/site/next-data/generators/releaseSchedule.mjs	Creates fetch function for release schedule data
apps/site/next-data/providers/releaseSchedule.ts	Provides cached access to release schedule data
apps/site/components/Releases/ReleaseSchedule/index.tsx	Implements the ReleaseSchedule component with SVG generation
apps/site/mdx/components.mjs	Registers ReleaseSchedule component for MDX usage
apps/site/pages/en/about/previous-releases.mdx	Replaces static image with ReleaseSchedule component
apps/site/next-env.d.ts	Updates TypeScript reference path (appears unintentional)

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/site/next-data/generators/releaseSchedule.mjs

pnpm-lock.yaml

Copilot · 2026-01-09T01:00:01Z

apps/site/components/Releases/ReleaseSchedule/index.tsx

+  return (
+    <div
+      dangerouslySetInnerHTML={{ __html: svg.html() }}
+      className="h-auto w-auto"
+    />


The generated SVG HTML is being directly injected using dangerouslySetInnerHTML without any sanitization. While the content comes from the 'lts' library, this could pose security risks if that library or the data it processes is compromised. Consider:

Validating/sanitizing the SVG output before rendering

Using a safer rendering method if possible

Adding comments explaining why dangerouslySetInnerHTML is necessary here

apps/site/components/Releases/ReleaseSchedule/index.tsx

apps/site/next-env.d.ts

avivkeller · 2026-01-09T03:09:09Z

📦 Build Size Comparison

Summary

Metric	Value
Old Total Size	3.74 MB
New Total Size	3.74 MB
Delta	2.00 B (0.00%)

Changes

➕ Added Assets (2)

Name	Size
`.next/static/chunks/ae5ac7216ec5dc2c.js`	13.14 KB
`.next/static/chunks/baf851974b01018e.js`	205.09 KB

➖ Removed Assets (2)

Name	Size
`.next/static/chunks/8e52d09c82cd16e3.js`	13.14 KB
`.next/static/chunks/aa3451220184e985.js`	205.09 KB

avivkeller · 2026-01-09T03:09:35Z

(I'll fix the comparator to comment on fork PRs)

avivkeller · 2026-01-09T03:11:52Z

pnpm-lock.yaml

+  jsdom@9.4.1:
+    resolution: {integrity: sha512-2M0vE8qIK0YF7apWYe0koqKsnChHKYtFqjoZpc1Mo6141TfoamZaCu6FvDVzXvMKYoFB+xGDuANgGDoyqrBt3Q==}
+


This is causing the warning. This JSDOM version is not the same version as the one we use (a few lines above), is there a package importing this version specifically, or would a dedupe fix it?

#8529 (comment)

vercel/next.js#76247 (comment)

avivkeller · 2026-01-09T03:15:18Z

apps/site/components/Releases/ReleaseSchedule/index.tsx

+
+  return (
+    <div
+      dangerouslySetInnerHTML={{ __html: svg.html() }}


While I understand the reason for this, is there a way to avoid this potentially dangerous situation?

Not that I'm aware of, svg.html() returns a simple string

I would probably then recommend finding a way to make this return a react node instead of raw html. Who maintains 'lts'? Can we make a @node-core/lts-react?

It's on Node.js domain

We can return variables like xScale, yScale, xAxis etc from the lts function and render the SVG inside our component using jsx.

Who maintains 'lts'

build wg but not really maintained. IMO it's can be a good idea to make it live here under web-infra team

We probably should have co-ownership, but this feels like smth that should be owned by releasers or build primarily.

Who maintains 'lts'

build wg but not really maintained. IMO it's can be a good idea to make it live here under web-infra team

@avivkeller @ovflowd I think @AugustinMauroy has a great point. The @nodejs/releasers showed they already have plans of getting rid of SVG, so maybe it's time for the @nodejs/nodejs-website to create our own version.

@avivkeller I don't think they have plans to get rid of the svg ;) what Richard stated was that the PR Guilherme originally opened didn't make sense for them on their PoV and should be done on our side.

I don't think we should have competing repositories for the lts svg source of truth tbh. All I'm saying is we can have shared ownership of the lts package if needed. Or make a new package that extends that one at maximum, but I'd like to avoid that route...

apps/site/next-data/generators/releaseSchedule.mjs

apps/site/next-data/providers/releaseSchedule.ts

avivkeller · 2026-01-09T03:18:19Z

apps/site/package.json

    "feed": "~5.1.0",
    "github-slugger": "~2.0.0",
    "gray-matter": "~4.0.3",
+    "lts": "github:araujogui/lts-schedule#refactor-website",


Adding blocked until then

apps/site/components/Releases/ReleaseSchedule/index.tsx

ovflowd · 2026-01-16T13:30:26Z

apps/site/components/Releases/ReleaseSchedule/index.tsx

+
+  return (
+    <div
+      dangerouslySetInnerHTML={{ __html: svg.html() }}


to be honest, I'm fine with this as long as server-side-rendering works.

Me too. We can refactor this by creating a component that does not use d3-node, but we'll end up with more duplicated code.

I'm fine too

feat: create release schedule component

48b0ce3

Copilot AI review requested due to automatic review settings January 9, 2026 00:55

araujogui requested review from a team as code owners January 9, 2026 00:55

Copilot started reviewing on behalf of araujogui January 9, 2026 00:55 View session

araujogui mentioned this pull request Jan 9, 2026

Website improvements nodejs/lts-schedule#30

Open

araujogui commented Jan 9, 2026

View reviewed changes

vercel bot deployed to Preview January 9, 2026 00:56 View deployment

araujogui commented Jan 9, 2026

View reviewed changes

Copilot AI reviewed Jan 9, 2026

View reviewed changes

malav2110 reviewed Jan 9, 2026

View reviewed changes

apps/site/next-env.d.ts Show resolved Hide resolved

avivkeller reviewed Jan 9, 2026

View reviewed changes

avivkeller added the blocked label Jan 9, 2026

avivkeller reviewed Jan 9, 2026

View reviewed changes

refactor: nits

62e16b3

vercel bot deployed to Preview January 9, 2026 12:59 View deployment

aduh95 reviewed Jan 13, 2026

View reviewed changes

apps/site/components/Releases/ReleaseSchedule/index.tsx Outdated Show resolved Hide resolved

ovflowd reviewed Jan 16, 2026

View reviewed changes

refactor: review

79429bb

vercel bot deployed to Preview January 16, 2026 15:13 View deployment

chore: revert next-env.d.ts

e732e4d

vercel bot deployed to Preview January 16, 2026 15:19 View deployment

		jsdom@9.4.1:
		resolution: {integrity: sha512-2M0vE8qIK0YF7apWYe0koqKsnChHKYtFqjoZpc1Mo6141TfoamZaCu6FvDVzXvMKYoFB+xGDuANgGDoyqrBt3Q==}

Uh oh!

feat: create release schedule component #8529

Are you sure you want to change the base?

feat: create release schedule component #8529

Conversation

araujogui commented Jan 9, 2026

Description

Validation

Related Issues

Check List

Uh oh!

vercel bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

👋 Codeowner Review Request

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Jan 9, 2026

📦 Build Size Comparison

Summary

Changes

Uh oh!

avivkeller commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovflowd Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Jan 9, 2026 •

edited

Loading

codecov bot commented Jan 9, 2026 •

edited

Loading

ovflowd Jan 17, 2026 •

edited

Loading