Skip to content

Conversation

@mag123c
Copy link
Contributor

@mag123c mag123c commented Oct 12, 2025

Fixes: #59417

Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had classname="test".
Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 12, 2025
@atlowChemi atlowChemi requested review from MoLow and pmarchini October 12, 2025 20:10
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (c1402c6) to head (175d312).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60220      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.02%     
==========================================
  Files         672      672              
  Lines      203930   203944      +14     
  Branches    39207    39213       +6     
==========================================
+ Hits       183082   183151      +69     
+ Misses      13175    13116      -59     
- Partials     7673     7677       +4     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.33% <100.00%> (+0.02%) ⬆️
lib/internal/test_runner/tests_stream.js 89.77% <100.00%> (+0.11%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from f738875 to 5e2a5d3 Compare October 13, 2025 00:26
@CuriousStork
Copy link

Hello @MoLow @pmarchini

Could you take a look? Thank you.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from 5e2a5d3 to 175d312 Compare January 26, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

6 participants