nextcloud/app_api#727: Clarify optional status #14000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the fix for nextcloud/app_api#727 points to the documentation then it would useful for users to have a clear message to explain that AppAPI is entirely optional and many of them won't need it at all. Signed-off-by: IBBoard <388582+IBBoard@users.noreply.github.com>
Contributor
|
It is nice to clarify, but from a performance and security point of view, wouldn't it make more sense to disable it by default and just enable it when it is really needed? |
Author
|
I totally agree. But according to the linked ticket then it's "core" functionality, and the solution was to downgrade the warning rather than giving a direct way to disable it, so I'm not holding my breath for anything more direct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
(Not sure how we're supposed to provide screenshots when GitHub doesn't render RST files!)