Skip to content

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Jan 21, 2026

Part of #62333.

  • Project tests manually needed an explicit "strict": false line added to each project file.
  • All evaluateTypeScript tests assume strict is implicitly off.
  • Fourslash tests from other PRs which I missed have an explicit // @strict: false

I think with this PR and #63023, we may be able to just flip the strict switch, accept baselines, and have tests pass.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR explicitly sets strict: false for existing tests that rely on non-strict mode behavior, as part of the larger effort (#62333) to make --strict the default in TypeScript. The changes ensure these tests continue to work correctly once the default is changed.

Changes:

  • Added "strict": false to 72 project test configuration JSON files
  • Updated corresponding baseline JSON files to reflect the new configuration
  • Added // @strict: false directive to 10 fourslash test files
  • Added strict: false to the evaluateTypeScript function's default compiler options

Reviewed changes

Copilot reviewed 260 out of 260 changed files in this pull request and generated no comments.

File Description
tests/cases/project/*.json (72 files) Added "strict": false to project test configurations
tests/baselines/reference/project//.json (144 files) Updated baseline files to reflect the new strict:false setting
tests/cases/fourslash/*.ts (10 files) Added // @strict: false compiler directive
src/harness/evaluatorImpl.ts Added strict: false to default compiler options for eval tests

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the evaluator tests really need strict? Or just alwaysStrict?

@DanielRosenwasser DanielRosenwasser added this pull request to the merge queue Jan 21, 2026
@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jan 21, 2026
Merged via the queue into main with commit e6fac66 Jan 21, 2026
38 of 39 checks passed
@DanielRosenwasser DanielRosenwasser deleted the strictProgrammaticTests branch January 21, 2026 02:37
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 21, 2026
@DanielRosenwasser
Copy link
Member Author

Do the evaluator tests really need strict? Or just alwaysStrict?

I believe they do - I think they consider any diagnostics to be a "syntax error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants