Use atomic writes to prevent file corruption #1435
Draft
+162
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please see this previous PR #1363 regarding the use of temp files |
Contributor
Author
I see, not sure what the right way could be then, i lose my contacts multiple times per day when testing things, meaning connecting/disconnecting/requesting contacts etc a lot and need to do a full erase + reflash after it without this change. I do use it on nRF but left it in draft for now, maybe there is a smarter way to prevent these losses. Not sure how often this happens with 'normal' usage though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had a few instances within a span of a couple of hours, where my flash got wiped after doing some intense BLE connect/disconnect/request data etc. Only a full erase and reflash seemed to fix it, although i could see it lost its identity etc already after a simple reboot.
Not the prettiest fix, but it seems it fixed it for me, so will leave the PR here in case people notice the same behavior and want to test this fix also.