Skip to content

Conversation

@OkunetsYurii
Copy link

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Changes Made

Testing

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Related Issues

Closes #

Screenshots (if applicable)

Additional Notes

@KSemenenko
Copy link
Member

@codex review and find a way to use different packages depending on on framework

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c79ee7319

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +15
#if NET9_0_OR_GREATER
return Guid.CreateVersion7();
#else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use v7 GUIDs on net8 targets

When targeting net8.0, this guard skips Guid.CreateVersion7() and falls back to Guid.NewGuid() (v4), which removes the monotonic/sortable ID behavior the command factories rely on for chronological ordering. .NET 8 already includes Guid.CreateVersion7, so builds for net8 will silently regress to non‑sortable IDs and any downstream logic that assumes v7 ordering (e.g., sorting or sharding by command id) will behave differently only on net8 targets. Consider switching the guard to NET8_0_OR_GREATER or providing a real v7 implementation for net8.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants