forked from invoke-ai/InvokeAI
-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature] Per-model CPU execution #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lstein
wants to merge
5
commits into
lstein/feature/per-model-cpu-execution
Choose a base branch
from
lstein/per-model-cpu-execution
base: lstein/feature/per-model-cpu-execution
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feature] Per-model CPU execution #46
lstein
wants to merge
5
commits into
lstein/feature/per-model-cpu-execution
from
lstein/per-model-cpu-execution
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Owner
Author
|
@copilot I'm getting this frontend linting error: |
5 tasks
…ement (#47) * Initial plan * Fix TypeScript linting errors for cpu_only field Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * chore(frontend) eslint * chore(frontend): prettier * Add missing popover translation for cpuOnly feature Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * Improve cpuOnly popover help text based on code review Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * Simplify CPU-only UI and add encoder support with device mismatch fix Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * Limit CPU-only execution to text encoders and ensure conditioning is moved to CPU for storage Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * Fix CPU-only execution to properly check model-specific compute device Co-authored-by: lstein <111189+lstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com> Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
Owner
Author
|
@copilot Can you make the front and backend changes needed to allow the user to change the cpu-only status of all the standalone encoder models? The best place to put the UI is in the model details pane for the various encoder models, using a layout similar to that used for Main models. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Complete ✅
This PR adds the ability to configure models to run on CPU instead of GPU on a per-model basis.
Changes Made
Backend:
cpu_onlyfield toMainModelDefaultSettingsModelCache.put()to accept optionalexecution_deviceparameterModelLoader._load_and_cache()to pass device from model configFrontend:
How to Use
NOTE:
After debugging, this should be merged into remote.
Original prompt