Allow case-insensitive Authorization header lookup #82
Conversation
Since reqwest downcases header names: > Header names are normalized to lower case. In other words, when > creating a HeaderName with a string, even if upper case characters are > included, when getting a string representation of the HeaderName, it > will be all lower case. This allows for faster HeaderMap comparison > operations. https://docs.rs/reqwest/latest/reqwest/header/index.html#headername
|
I've assigned @tankyleo as a reviewer! |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
TIL thank you ! Let's also do the same in the JWT implementation
| let auth_header = headers_map | ||
| .get("Authorization") | ||
| .iter() | ||
| .find_map( |
There was a problem hiding this comment.
Hmm rather than iterating over all the headers here, I think we can safely make the assumption that all the keys will be lowercased, and do get("authorization") directly. WDYT ?
There was a problem hiding this comment.
Since the Authorizer trait is internal to vss-server, I think we should do this, and add a quick doc in the Authorizer trait definition along the lines of "implementations can assume all header names to be lower case"
3 participants
Since reqwest downcases header names:
https://docs.rs/reqwest/latest/reqwest/header/index.html#headername