Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 22, 2026

Note

Unifies key handling to symbols across FDv2

  • Normalize keys to Symbol in Change, ChangeSetBuilder#add_put/#add_delete, Protocol V2 (PutObject.from_h, DeleteObject.from_h), polling parsers (polling_payload_to_changeset, fdv1_polling_payload_to_changeset), and TestData V2 emitters
  • InMemoryFeatureStoreV2#get now accepts string/symbol lookups via key.to_sym; store/data sorting and dependency tracking updated to operate on symbol keys
  • Store writes/reads (changes_to_store_data, reset/apply, persistence paths) and FeatureStore interface docs updated to use symbol inner keys; FeatureStore#get docs accept String, Symbol
  • TestDataV2 and its data source convert keys to symbols on update for flags/segments
  • Extensive spec updates/additions validating key compatibility, polling/streaming behavior, FDv1 fallback paths, and persistent store outage recovery/flush in read-write vs read-only modes

Written by Cursor Bugbot for commit 4e9325c. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review January 22, 2026 19:45
@jsonbailey jsonbailey requested a review from a team as a code owner January 22, 2026 19:45
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Base automatically changed from jb/sdk-1545/fdv2-streaming-data-source to main January 22, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants