Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 13, 2026

Note

Introduces FDv2 streaming support and integrates it behind an opt-in configuration.

  • Adds StreamingDataSourceV2 (SSE-based) with error handling, heartbeats, FDv1 fallback via headers, and diagnostics; includes builder StreamingDataSourceBuilder
  • Extends LaunchDarkly::DataSystem with streaming_ds_builder and predefined configs (default, streaming, polling); updates LDClient to use FDv2 when config.data_system_config is set, otherwise FDv1
  • Renames config option/accessor to data_system_config and updates references/examples
  • Converts FDv2 event names to symbols and aligns consumers (polling payload parsing, protocol docs/returns)
  • Increases ld-eventsource runtime dependency to 2.4.0
  • Adds unit tests for streaming message handling and error/reset behavior

Written by Cursor Bugbot for commit ab01cd4. This will update automatically on new commits. Configure here.

Base automatically changed from jb/sdk-1544/fdv2-polling-data-source to main January 20, 2026 17:55
@jsonbailey jsonbailey marked this pull request as ready for review January 20, 2026 18:52
@jsonbailey jsonbailey requested a review from a team as a code owner January 20, 2026 18:52
cursor[bot]

This comment was marked as outdated.

@jsonbailey jsonbailey marked this pull request as draft January 21, 2026 15:08
@jsonbailey jsonbailey marked this pull request as ready for review January 21, 2026 20:52
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@jsonbailey jsonbailey merged commit add7638 into main Jan 22, 2026
10 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1545/fdv2-streaming-data-source branch January 22, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants