-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add FDv2 Streaming Synchronizer #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-fdv2-data-source-interfaces
…unchdarkly/java-core into rlamb/add-fdv2-data-source-interfaces
…ming-synchronizer
Base automatically changed from
rlamb/add-fdv2-data-source-interfaces
to
main
January 15, 2026 23:31
kinyoklion
commented
Jan 16, 2026
| case NONE: | ||
| break; | ||
| case INTERNAL_ERROR: { | ||
| FDv2ProtocolHandler.FDv2ActionInternalError internalErrorAction = (FDv2ProtocolHandler.FDv2ActionInternalError) res; |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gap identified working on streaming.
Member
Author
|
bugbot review |
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
tanderson-ld
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Add FDv2 Streaming Synchronizer
END_COMMIT_OVERRIDE
Note
Adds FDv2 streaming support and refines polling behavior
StreamingSynchronizerImplmaintains an SSE connection viaEventSource, parses FDv2 events, emitsCHANGE_SET/status results, handles recoverable/non-recoverable errors, restarts onGOODBYE, and lazily starts onnext(); supports selector andfilterquery paramsINTERNAL_ERRORtypes (MISSING_PAYLOAD,JSON_ERROR) toINVALID_DATA;PollingSynchronizerImplnow completes a shutdown future on terminal errors to stop further pollingInitializerandSynchronizer(state diagrams;next()usage on shutdown/terminal)Written by Cursor Bugbot for commit d4dff45. This will update automatically on new commits. Configure here.