Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Jan 15, 2026

BEGIN_COMMIT_OVERRIDE
chore: Add FDv2 Streaming Synchronizer
END_COMMIT_OVERRIDE

Note

Adds FDv2 streaming support and refines polling behavior

  • New StreamingSynchronizerImpl maintains an SSE connection via EventSource, parses FDv2 events, emits CHANGE_SET/status results, handles recoverable/non-recoverable errors, restarts on GOODBYE, and lazily starts on next(); supports selector and filter query params
  • Polling updates: map specific INTERNAL_ERROR types (MISSING_PAYLOAD, JSON_ERROR) to INVALID_DATA; PollingSynchronizerImpl now completes a shutdown future on terminal errors to stop further polling
  • API docs clarified for Initializer and Synchronizer (state diagrams; next() usage on shutdown/terminal)
  • Extensive tests added for streaming behaviors (events, reconnection, errors, selector/filter) and for polling internal-error kinds and shutdown/continuation

Written by Cursor Bugbot for commit d4dff45. This will update automatically on new commits. Configure here.

tanderson-ld and others added 30 commits January 12, 2026 11:47
…unchdarkly/java-core into rlamb/add-fdv2-data-source-interfaces
Base automatically changed from rlamb/add-fdv2-data-source-interfaces to main January 15, 2026 23:31
case NONE:
break;
case INTERNAL_ERROR: {
FDv2ProtocolHandler.FDv2ActionInternalError internalErrorAction = (FDv2ProtocolHandler.FDv2ActionInternalError) res;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gap identified working on streaming.

@launchdarkly launchdarkly deleted a comment from cursor bot Jan 16, 2026
@launchdarkly launchdarkly deleted a comment from cursor bot Jan 16, 2026
@launchdarkly launchdarkly deleted a comment from cursor bot Jan 16, 2026
@launchdarkly launchdarkly deleted a comment from cursor bot Jan 16, 2026
@kinyoklion
Copy link
Member Author

bugbot review

@kinyoklion kinyoklion closed this Jan 16, 2026
@kinyoklion kinyoklion reopened this Jan 16, 2026
@kinyoklion kinyoklion marked this pull request as ready for review January 16, 2026 00:58
@kinyoklion kinyoklion requested a review from a team as a code owner January 16, 2026 00:58
@kinyoklion kinyoklion merged commit 211783a into main Jan 21, 2026
21 checks passed
@kinyoklion kinyoklion deleted the rlamb/streaming-synchronizer branch January 21, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants