fix: return non-zero exit code when status unavailable

[thc1006]

What this PR does

Fixes minikube status returning exit code 0 when the Docker container does not exist.

Root cause: When cluster.GetStatus() fails, it returns nil statuses. The exitCode() function's for-loop doesn't execute for nil/empty slices, returning 0.

Fix: Add nil/empty check at the start of exitCode() to return 7 (all components not running).

Changes

• cmd/minikube/cmd/status.go: Add nil check in exitCode() (+3 lines)
• cmd/minikube/cmd/status_test.go: Add test cases for nil and empty statuses (+16 lines)

Verification

• exitCode() function: 100% test coverage
• All unit tests pass
• Lint passes (0 issues)
• Manual test: exit code = 7 when container missing

Fixes #22466

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thc1006
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @thc1006!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @thc1006. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This PR fixes a bug where minikube status incorrectly returns exit code 0 when the Docker container does not exist. The root cause is that cluster.GetStatus() returns nil when it fails, and the exitCode() function's loop doesn't execute for nil/empty slices, resulting in an incorrect 0 return.

Changes:

• Added nil/empty check in exitCode() to return exit code 7 (all components not running)
• Added test cases for nil and empty status slices to ensure proper coverage

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/minikube/cmd/status.go	Added early return in exitCode() to handle nil/empty statuses by returning exit code 7
cmd/minikube/cmd/status_test.go	Added test cases for nil and empty status scenarios to verify correct exit code behavior

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[minikube-bot]

Can one of the admins verify this patch?