-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use the minikube version of crun buildroot package #22434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The package was renamed from "crun" to "crun-latest", but the dependencies were never updated to match... So it was using crun 1.18.2 from buildroot 2025.02.x, instead of crun 1.26 in the minikube external packages.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
ok-to-build-iso |
|
Hi @afbjorklund, building a new ISO failed for Commit 2ac0fa5 |
Apparently it was never tested, after being renamed. Make sure to construct <git-version.h> from tarball.
|
ok-to-build-iso |
|
@afbjorklund: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @afbjorklund, building a new ISO failed for Commit 4a19153 |
|
ok-to-build-iso |
|
Hi @afbjorklund, building a new ISO failed for Commit 4a19153 |
|
Seems like Jenkins is forgetting to put the new go version in the PATH, and then failing the build: WARNING: expected go version to be 1.25.5 but got 1.18.1 It should use new go first: |
The package was renamed from "crun" to "crun-latest", but the dependencies were never updated to match...
commit 0191b98
So it was using crun 1.18.2 from buildroot 2025.02.x, instead of crun 1.26 in the minikube external packages.
EDIT: Apparently crun-latest was never tested after the rename either, since the package failed to build
It was trying to download https://github.com/containers/crun/releases/download/1.26/crun-latest-1.26.tar.gz
CONMON_LATEST?
There is a fair chance that it will need a version of conmon too, that matches the custom podman and cri-o.
At least if trying to updated podman and cri-o, from the current legacy versions to something more recent.
Currently it is just using the version in buildroot, and thus getting conmon 2.1.8 instead of conmon 2.1.13
Apparently minikube "containerd-bin" is missing the dependency on "runc-master" altogether...
But it is saved by the auto-default in runc-master, that is missing from the crun-latest package.