Skip to content

Conversation

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Jan 11, 2026

The package was renamed from "crun" to "crun-latest", but the dependencies were never updated to match...

commit 0191b98

So it was using crun 1.18.2 from buildroot 2025.02.x, instead of crun 1.26 in the minikube external packages.

BR2_PACKAGE_CRUN=y
# BR2_PACKAGE_CRUN_LATEST is not set

EDIT: Apparently crun-latest was never tested after the rename either, since the package failed to build

It was trying to download https://github.com/containers/crun/releases/download/1.26/crun-latest-1.26.tar.gz

  • 64de71e Kicbase/ISO: Update crun from 1.23.1 to 1.26
  • 03a3c91 Kicbase/ISO: Update crun from 1.23 to 1.23.1
  • 0afbdc5 Kicbase/ISO: Update crun from 1.19 to 1.23
  • 7e1077f Kicbase/ISO: Update crun from 1.18.2 to 1.19
  • 7cf7040 Kicbase/ISO: Update crun from 1.18 to 1.18.2
  • 79ad880 Kicbase/ISO: Update crun from 1.17 to 1.18
  • b0b1a5d Kicbase/ISO: Update crun from 1.16.1 to 1.17
  • b753489 Kicbase/ISO: Update crun from 1.16 to 1.16.1
  • 820e515 Kicbase/ISO: Update crun from 1.15 to 1.16
  • 3afdff0 Kicbase/ISO: Update crun from 1.14.4 to 1.15
  • f0f00db Kicbase/ISO: Update crun from 1.14 to 1.14.4
  • 84691f8 Kicbase/ISO: Update crun from v1.2 to v1.14
  • 0191b98 iso/package: Move crun to crun-latest
  • 5ca792e Upgrade crun to 1.2

CONMON_LATEST?

There is a fair chance that it will need a version of conmon too, that matches the custom podman and cri-o.
At least if trying to updated podman and cri-o, from the current legacy versions to something more recent.

Currently it is just using the version in buildroot, and thus getting conmon 2.1.8 instead of conmon 2.1.13


Apparently minikube "containerd-bin" is missing the dependency on "runc-master" altogether...

But it is saved by the auto-default in runc-master, that is missing from the crun-latest package.

# BR2_PACKAGE_RUNC is not set
BR2_PACKAGE_RUNC_MASTER=y

The package was renamed from "crun" to "crun-latest",
but the dependencies were never updated to match...

So it was using crun 1.18.2 from buildroot 2025.02.x,
instead of crun 1.26 in the minikube external packages.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs January 11, 2026 16:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2026
@afbjorklund afbjorklund changed the title Use the minikube version of crun package Use the minikube version of crun buildroot package Jan 11, 2026
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed for Commit 2ac0fa5
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22434/2ac0fa5/iso_build.txt

Apparently it was never tested, after being renamed.

Make sure to construct <git-version.h> from tarball.
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot
Copy link
Contributor

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-vfkit-docker-macos-arm 4a19153 link false /test integration-vfkit-docker-macos-arm
integration-docker-containerd-linux-arm 4a19153 link false /test integration-docker-containerd-linux-arm
integration-docker-containerd-linux-x86 4a19153 link true /test integration-docker-containerd-linux-x86
integration-docker-crio-linux-x86 4a19153 link false /test integration-docker-crio-linux-x86
integration-kvm-crio-linux-x86 4a19153 link false /test integration-kvm-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed for Commit 4a19153
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22434/4a19153/iso_build.txt

@Dustinturner44 Dustinturner44 mentioned this pull request Jan 12, 2026
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new ISO failed for Commit 4a19153
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22434/4a19153/iso_build.txt

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jan 17, 2026

Seems like Jenkins is forgetting to put the new go version in the PATH, and then failing the build:

WARNING: expected go version to be 1.25.5 but got 1.18.1

GOOS=linux GOARCH=arm64 go build -o out/auto-pause-arm64 cmd/auto-pause/auto-pause.go
go: errors parsing go.mod:
/home/jenkins/workspace/iso-pr-build/go.mod:3: invalid go version '1.25.0': must match format 1.23
make: *** [Makefile:806: out/auto-pause-arm64] Error 1

It should use new go first: export PATH=$PATH:"/usr/local/bin/:/usr/local/go/bin/:$GOPATH/bin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants