CDM-461: Add token type field to returned Token class #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 277 299 +22
=========================================
+ Hits 277 299 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dauglyon
reviewed
Jan 22, 2026
Comment on lines
+75
to
+82
| _STR2TYPE = { | ||
| "login": TokenType.LOGIN, | ||
| "agent": TokenType.AGENT, | ||
| "developer": TokenType.DEVELOPER, | ||
| "service": TokenType.SERVICE, | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
seems to be equivalent to _STR2TYPE = {t.name.lower(): t for t in TokenType}
Member
Author
There was a problem hiding this comment.
I think I'm going to leave it as is just because the mfa enum is done the same way and the input names aren't just lower case of the MFA enum names
dauglyon
approved these changes
Jan 22, 2026
dauglyon
left a comment
dauglyon
left a comment
There was a problem hiding this comment.
LGTM, values match auth2 token type enum, tests cover. One extremely minor comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.