-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…abilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving six identified vulnerabilities within its yarn dependencies. The changes involve updating several Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 2 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix security vulnerabilities by updating dependencies in plugins/techdocs-addons-test-utils/package.json. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace: package links with pinned, outdated versions, which will likely break the project. My review includes a critical comment explaining why these changes should be reverted and suggests an alternative approach to resolving the vulnerabilities.
| "@backstage/core-app-api": "0.1.0", | ||
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-search-react": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs-react": "workspace:^", | ||
| "@backstage/test-utils": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", | ||
| "@backstage/plugin-techdocs-react": "0.1.0", | ||
| "@backstage/test-utils": "0.1.1", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes incorrectly replace workspace:^ dependencies with pinned, outdated versions. This will likely break the build and local development workflow.
In a Yarn workspace monorepo, workspace:^ is used to link to other packages within the same monorepo. By removing it and pinning to old versions, you are forcing this package to use old, published versions from the registry instead of the current code in your local repository.
For example:
@backstage/core-app-apiis being downgraded from the workspace version (likely1.9.1-next.0based on the repo) to0.1.0.@backstage/core-componentsis being downgraded from its workspace version (e.g.,0.13.4-next.0) to0.1.0.
This is a significant downgrade and will almost certainly cause issues.
While this PR was automatically generated by Snyk to fix vulnerabilities, the proposed changes are not suitable for this project's structure. The correct approach would be to identify the vulnerable transitive dependencies and update them, or update the @backstage packages themselves, while retaining the workspace:^ protocol. The PR also notes that yarn.lock was not updated, which is another critical issue.
I recommend reverting these changes and addressing the vulnerabilities by other means, such as updating the relevant packages across the monorepo and regenerating the lockfile.
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Deps as Dependencies
Note over Dev,Deps: Dependency Version Pinning Process
Dev->>PM: Update package.json
Note right of Dev: Change workspace:^ to<br/>specific versions
PM->>Deps: Resolve @backstage/core-app-api@0.1.0
PM->>Deps: Resolve @backstage/core-components@0.1.0
PM->>Deps: Resolve @backstage/plugin-techdocs@0.1.1
PM->>Deps: Resolve @backstage/plugin-techdocs-react@0.1.0
PM->>Deps: Resolve @backstage/test-utils@0.1.1
PM->>Deps: Resolve @backstage/theme@0.1.1
Deps-->>PM: Return resolved packages
PM-->>Dev: Dependencies locked to specific versions
Note over Dev,Deps: No runtime behavior changes<br/>Only build-time dependency resolution
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/techdocs-addons-test-utils/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions dependency specifications from workspace protocol to explicit semantic versions in the techdocs-addons-test-utils plugin.
workspace:^to specific versions (0.1.0 or 0.1.1)plugins/techdocs-addons-test-utils/package.json