-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by resolving six identified vulnerabilities within its Yarn dependencies. The changes involve precise version updates for two core Backstage dependencies in a specific plugin's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several vulnerabilities by modifying dependencies. However, the proposed changes are incorrect for this monorepo project. It replaces workspace:^ dependencies with specific, outdated versions for @backstage/core-components and @backstage/theme. This breaks the monorepo's dependency management strategy, which relies on using local packages from the workspace.
The changes would cause significant downgrades and likely lead to build failures, runtime errors, or other inconsistencies. As noted in the PR description, yarn.lock also failed to update, indicating issues with the automated process.
I have added a critical comment to revert these changes. It is strongly recommended to close this PR and address the vulnerabilities manually, for instance by using resolutions in the root package.json to force newer, non-vulnerable versions of transitive dependencies.
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes incorrectly replace workspace dependencies with fixed, much older versions. In this monorepo setup, "workspace:^" ensures that this plugin uses the @backstage/core-components and @backstage/theme packages from this same repository.
@backstage/core-componentswould be downgraded from workspace version0.13.4-next.0to0.1.0.@backstage/themewould be downgraded from workspace version0.4.1to0.1.1.
Pinning to these outdated versions from the npm registry will break the monorepo's dependency integrity and likely cause version mismatches, build failures, or runtime errors. These changes should be reverted. To fix the underlying vulnerabilities, consider using resolutions in the root package.json or updating the vulnerable transitive dependencies through their direct parents.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^"
WalkthroughThis PR updates dependency management for the example-todo-list plugin by transitioning from workspace protocol references to fixed version specifications. The changes pin two Backstage packages to specific versions: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
participant Plugin as example-todo-list
Note over Dev,Plugin: Dependency Resolution Change
Dev->>Plugin: Update package.json
Note right of Plugin: Pin versions:<br/>core-components: 0.1.0<br/>theme: 0.1.1
Dev->>PM: Run install command
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/core-components
WS-->>PM: Return local workspace version
PM->>WS: Resolve @backstage/theme
WS-->>PM: Return local workspace version
else After Change (specific versions)
PM->>NPM: Fetch @backstage/core-components@0.1.0
NPM-->>PM: Return package
PM->>NPM: Fetch @backstage/theme@0.1.1
NPM-->>PM: Return package
end
PM->>Plugin: Install dependencies
Plugin-->>Dev: Build ready with pinned versions
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/example-todo-list/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR pins Backstage dependencies to specific versions in the example-todo-list plugin package configuration.
@backstage/core-componentsfromworkspace:^to fixed version0.1.0@backstage/themefromworkspace:^to fixed version0.1.1plugins/example-todo-list/package.json