Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 25, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/catalog-graphql/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  208  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR transitions the catalog-graphql plugin from workspace dependencies to fixed package versions.

  • Changed @backstage/catalog-model from workspace:^ to 0.1.1
  • Changed @backstage/types from workspace:^ to 0.1.1
  • Indicates preparation for package publication or migration away from monorepo workspace setup

@codesandbox
Copy link

codesandbox bot commented Jan 25, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to bolster the project's security by upgrading key dependencies within the plugins/catalog-graphql module. It specifically pins @backstage/catalog-model and @backstage/types to version 0.1.1 to remediate a total of six security vulnerabilities, including one high-severity and multiple medium-severity issues.

Highlights

  • Security Vulnerability Fixes: This pull request, automatically generated by Snyk, addresses 6 identified security vulnerabilities by updating specific dependencies.
  • Dependency Version Pinning: The @backstage/catalog-model and @backstage/types dependencies in plugins/catalog-graphql/package.json have been updated from workspace:^ to a fixed version 0.1.1.
  • Impacted Vulnerabilities: The fixes target issues including a high-severity UNIX Symbolic Link (Symlink) Following vulnerability, and several medium-severity issues such as Improper Handling of Unicode Encoding, Use of a Cryptographic Primitive with a Risky Implementation, Prototype Pollution, and Regular Expression Denial of Service (ReDoS).
  • Zero-Install Users Warning: Users employing Yarn's zero-installs feature are advised that yarn.lock was not updated by this PR and a manual yarn run is required to update the .yarn/cache/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 25, 2026

Snyk checks have failed. 6 issues have been found so far.

Status Scanner Critical High Medium Low Total (6)
Open Source Security 0 4 2 0 6 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix several vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace-local dependencies (workspace:^) with old, pinned versions from the public registry for @backstage/catalog-model and @backstage/types. This will likely break the project as it introduces significant version downgrades and breaks the yarn workspace linking. The changes should be reverted, and the vulnerabilities should be addressed by either updating the parent dependencies or using yarn resolutions while preserving the workspace setup.

Comment on lines +39 to +41
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Snyk bot has incorrectly modified these dependencies. It has replaced workspace:^ with pinned, outdated versions for @backstage/catalog-model and @backstage/types. This project is a monorepo using yarn workspaces, and this change breaks the workspace linking, forcing the use of old package versions from the registry instead of the local packages from the workspace.

The versions pinned are:

  • @backstage/catalog-model: 0.1.1 (the version in this workspace is 1.4.1)
  • @backstage/types: 0.1.1 (the version in this workspace is 1.1.0)

Using these significantly older versions will likely cause build failures or runtime errors due to API incompatibilities. The PR description also notes that yarn.lock failed to update, which is another indicator of problems.

The correct approach is to revert these changes and address the underlying vulnerabilities, likely by using resolutions in the root package.json to force newer, non-vulnerable versions of the transitive dependencies.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management strategy for the catalog-graphql plugin by replacing workspace protocol references with fixed version numbers. Specifically, two Backstage packages (@backstage/catalog-model and @backstage/types) are pinned to version 0.1.1 instead of using the workspace:^ protocol. This change indicates a transition from monorepo workspace dependencies to externally published package versions, which is typically done when preparing a package for independent publication or when decoupling from a workspace-based development setup.

Changes

File(s) Summary
plugins/catalog-graphql/package.json Updated @backstage/catalog-model and @backstage/types dependency versions from workspace:^ to fixed version 0.1.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant PM as Package Manager
    participant CG as catalog-graphql Plugin
    participant CM as @backstage/catalog-model
    participant BT as @backstage/types

    Note over PM,BT: Dependency Resolution Process

    PM->>CG: Read package.json
    Note over CG: Dependencies updated:<br/>catalog-model: 0.1.1<br/>types: 0.1.1

    PM->>CM: Resolve @backstage/catalog-model@0.1.1
    Note right of CM: Previously: workspace:^<br/>Now: Fixed version 0.1.1
    CM-->>PM: Return resolved package

    PM->>BT: Resolve @backstage/types@0.1.1
    Note right of BT: Previously: workspace:^<br/>Now: Fixed version 0.1.1
    BT-->>PM: Return resolved package

    PM->>CG: Install dependencies
    Note over CG: catalog-graphql now uses<br/>fixed versions instead of<br/>workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants