Add editorIds and memberIds arrays to the PublicSpace type returned by Space.findManyPublic() and `usePublicSpaces()
#581
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rned by `Space.findManyPublic()` and `usePublicSpaces()
nikgraf
force-pushed
the
add-memberIds-and-editorIds
branch
from
9b435d4 to
1405a67
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds editorIds and memberIds arrays to the PublicSpace type, allowing consumers to access the list of editor and member space IDs for public spaces.
Changes:
- Extended GraphQL queries to fetch
editorsListandmembersListwith theirmemberSpaceIdfields - Added
editorIdsandmemberIdsas required array fields to thePublicSpaceSchema - Implemented helper functions to extract and filter the IDs from query results
- Updated all existing tests and added a new test case to verify the parsing of editor and member IDs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hypergraph/src/space/find-many-public.ts | Added GraphQL fields, schema properties, type definitions, and helper functions to support editorIds and memberIds |
| packages/hypergraph/test/space/find-many-public.test.ts | Updated test helper and existing test expectations, added new test case for parsing editorIds and memberIds |
| .changeset/add-editor-member-ids.md | Documented the feature addition as a minor version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.