feat: Upgrade protobuf runtime and gen code to 4.33.x (#4000)

[blakeli0]

Protobuf-java v4.33.x restored gen code compatibility to 3.0.0. Upgrade protobuf runtime and gen code to 4.33.x should have minimum risks now. See
go/cloud-java:protobuf-4.x-upgrade for details.

[gemini-code-assist]

Summary of Changes

Hello @blakeli0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant infrastructure update, migrating the project's Protobuf dependencies to version 4.33.x. This upgrade is crucial for maintaining compatibility and leveraging the latest features and performance improvements offered by Protobuf. The changes are primarily confined to build configurations and the automatically generated Java source files, ensuring a consistent and modern Protobuf environment across the codebase.

Highlights

• Protobuf Version Upgrade: The pull request upgrades the Protobuf compiler (PROTOC_VERSION) in cloudbuild configurations from 25.8 to 33.2 and the protobuf.version in the pom.xml to 4.33.0.
• Generated Code Updates: All generated Java Protobuf files have been updated to reflect the new version, including changes from com.google.protobuf.GeneratedMessageV3 to com.google.protobuf.GeneratedMessage, the addition of @com.google.protobuf.Generated annotations, and runtime version validation checks.
• API Modernization: Deprecated methods and patterns within Protobuf's generated code, such as newInstance(UnusedPrivateParameter unused) and various builder methods (clone, setField, etc.), have been removed or updated to align with the 4.33.x API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully upgrades the Protobuf runtime and regenerates the associated Java code to version 4.33.x. The changes observed across the various .java and .Dockerfile files are consistent with a standard Protobuf version upgrade, including API changes in GeneratedMessage and GeneratedMessageV3 classes, new runtime version validation, and internal optimizations for repeated fields. The pom.xml also correctly reflects the new Protobuf dependency version. No issues were found that require specific comments.

[sonarqubecloud]

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
18.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud