init code for exposing metadata ops into grpcCient #1718
Conversation
product-auto-label
bot
added
size: m
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational code for exposing metadata operations within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces an async_grpc_client with a delete_object method and includes corresponding unit and system tests. The delete_object method correctly constructs the gRPC request. However, there are some inconsistencies and potential issues in the system test's usage of the new method and a minor documentation detail in the async_grpc_client's docstring. The example usage in async_grpc_client.py also has a minor issue with error re-raising.
| await writer.append(b'some_bytes') | ||
| await writer.close() | ||
|
|
||
| await grpc_client.delete_object(bucket=f"projects/_/buckets/{_ZONAL_BUCKET}", object_=object_name) |
There was a problem hiding this comment.
The delete_object method of AsyncGrpcClient expects bucket_name and object_name as arguments, not bucket and object_. The method itself handles the formatting of the bucket path. Please adjust the parameter names accordingly.
| await grpc_client.delete_object(bucket=f"projects/_/buckets/{_ZONAL_BUCKET}", object_=object_name) | |
| await grpc_client.delete_object(bucket_name=_ZONAL_BUCKET, object_name=object_name) |
| """ | ||
| Test that a new writer when specifies `None` overrides the existing object. |
There was a problem hiding this comment.
The docstring for test_delete_object_using_grpc_client is incorrect. It describes a test for overriding an existing object, not for deleting an object. Please update it to accurately reflect the purpose of this test.
| """ | |
| Test that a new writer when specifies `None` overrides the existing object. | |
| """ | |
| Test that `delete_object` using the gRPC client successfully deletes an object. | |
| """ |
| with pytest.raises(NotFound): | ||
| await grpc_client.get_object(bucket=f"projects/_/buckets/{_ZONAL_BUCKET}", object_=object_name) |
There was a problem hiding this comment.
The grpc_client fixture returns an instance of _storage_v2.StorageAsyncClient, which has a get_object method that expects bucket and object_ as keyword arguments, with bucket being the full resource path. However, AsyncGrpcClient does not expose a get_object method directly. If the intention is to use the underlying GAPIC client, the parameters are correct. If AsyncGrpcClient is intended to be the primary interface, then a get_object method should be added to AsyncGrpcClient for consistency, or this test should explicitly call grpc_client._grpc_client.get_object if grpc_client refers to the AsyncGrpcClient wrapper.
Given the delete_object call above is using the AsyncGrpcClient's wrapper method, it would be more consistent to either:
- Add a
get_objectwrapper method toAsyncGrpcClient. - Call
grpc_client.grpc_client.get_objectdirectly ifgrpc_clientrefers to theAsyncGrpcClientinstance (which it doesn't in this fixture, it refers to the underlying GAPIC client).
For now, assuming grpc_client is the GAPIC client, the parameters are correct, but the inconsistency with delete_object is notable.
| (Optional) If present, permanently deletes a specific generation | ||
| of an object. | ||
| :type if_generation_match: long |
There was a problem hiding this comment.
The docstring specifies :type if_generation_match: long. In Python, long is not a distinct type from int since Python 3. It should be int for consistency and accuracy.
| :param if_generation_match: | ||
| (Optional) See :ref:`using-if-generation-match` | ||
| :type if_generation_not_match: long |
There was a problem hiding this comment.
The docstring specifies :type if_generation_not_match: long. In Python, long is not a distinct type from int since Python 3. It should be int for consistency and accuracy.
| :param if_generation_not_match: | ||
| (Optional) See :ref:`using-if-generation-not-match` | ||
| :type if_metageneration_match: long |
There was a problem hiding this comment.
The docstring specifies :type if_metageneration_match: long. In Python, long is not a distinct type from int since Python 3. It should be int for consistency and accuracy.
| :param if_metageneration_match: | ||
| (Optional) See :ref:`using-if-metageneration-match` | ||
| :type if_metageneration_not_match: long |
There was a problem hiding this comment.
The docstring specifies :type if_metageneration_not_match: long. In Python, long is not a distinct type from int since Python 3. It should be int for consistency and accuracy.
| print("Object deleted successfully.") | ||
| except Exception as e: | ||
| print(f"An error occurred: {e}") | ||
| raise |
There was a problem hiding this comment.
When re-raising an exception caught in an except block, it's generally clearer to explicitly re-raise the caught exception e to preserve the original traceback. While raise alone re-raises the last exception, raise e is more explicit.
| raise | |
| raise e |
1 participant
init code for exposing metadata ops into grpcCient