feat: add state_delta - optional state changes to apply to the session #4192
Conversation
Summary of ChangesHello @yingyinggu-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @yingyinggu-dev, thank you for creating this PR! In order to help the reviewers to better understand the context of this PR, could you please fill out the PR template and provide the following information?
This information will help reviewers to review your PR more efficiently. Thanks! |
adk-bot
added
the
live
|
Response from ADK Triaging Agent Hello @yingyinggu-dev, thank you for creating this PR! Could you please fill out the PR template, including the link to an issue (or a description of the change) and the testing plan? This information will help reviewers to review your PR more efficiently. Thanks! |
|
Response from ADK Triaging Agent Hello @yingyinggu-dev, thank you for creating this PR! Could you please associate a GitHub issue with this PR? If one doesn't exist, you can create one or describe the feature in the PR description. Additionally, could you please provide a testing plan in the PR description to detail how you've tested these changes? This information will help reviewers to review your PR more efficiently. Thanks! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an optional state_delta parameter to the run_live method, allowing for state changes to be applied to the session at the beginning of a live run. The implementation is sound and follows existing patterns in the codebase for creating and appending events. My main feedback is a suggestion to refactor the logic for creating state change events to reduce code duplication across the Runner class, which could be addressed in a follow-up.
| if state_delta: | ||
| state_event = Event( | ||
| invocation_id=invocation_context.invocation_id, | ||
| author='user', | ||
| actions=EventActions(state_delta=state_delta), | ||
| ) | ||
| _apply_run_config_custom_metadata(state_event, run_config) | ||
| await self.session_service.append_event(session=session, event=state_event) |
There was a problem hiding this comment.
The logic to create and append a state change event is similar to logic in other methods like _append_new_message_to_session and rewind_async. To improve maintainability and reduce code duplication, consider extracting this into a private helper method in a follow-up change. A shared helper would centralize the creation of these control events.
For example, a helper could look like this:
async def _append_control_event(self, session: Session, invocation_context: InvocationContext, actions: EventActions, run_config: Optional[RunConfig]):
event = Event(
invocation_id=invocation_context.invocation_id,
author='user',
actions=actions,
)
_apply_run_config_custom_metadata(event, run_config)
await self.session_service.append_event(session=session, event=event)2 participants
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.pytest tests/unittests/test_runners.py::test_run_live_state_delta_applied_to_session -v
===test session starts===
tests/unittests/test_runners.py::test_run_live_state_delta_applied_to_session PASSED [100%]
=== 1 passed in 3.30s ===
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.