Skip to content

fix: resolve tox not found error make test from package directories #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tuan-tran-thanh wants to merge 1 commit into from
Closed

fix: resolve tox not found error make test from package directories #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions project_common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ format-diff:

.PHONY: mypy
mypy:
uv run tox $(TOX_FLAGS) -e mypy
(cd $(ROOT_DIR); uv sync --group tox > /dev/null 2>&1) && $(ROOT_DIR)/.venv/bin/tox $(TOX_FLAGS) -e mypy
Copy link
Contributor

@hkad98 hkad98 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the .venv created and populated during make dev. Installing dependencies at runtime is non-optimal and is also a side effect.


.PHONY: types
types: mypy

.PHONY: test
test:
uv run tox -v $(TOX_FLAGS) $(LOCAL_TEST_ENVS) $(LOCAL_ADD_ARGS)
(cd $(ROOT_DIR); uv sync --group tox > /dev/null 2>&1) && $(ROOT_DIR)/.venv/bin/tox -v $(TOX_FLAGS) $(LOCAL_TEST_ENVS) $(LOCAL_ADD_ARGS)

.PHONY: test-ci
test-ci:
Expand Down
Loading