feat(stdlib): Handle proxy tunnels in httlib integration #5303
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/stdlib-proxy
branch
from
7c49a36 to
bf37a48
Compare
sl0thentr0py
changed the title
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Ai
Other
Bug Fixes 🐛Integrations
Litellm
Other
Documentation 📚
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
sl0thentr0py
commented
Jan 13, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
alexander-alderman-webb
approved these changes
Jan 13, 2026
sentry_sdk/integrations/stdlib.py
Outdated
| tunnel_port = getattr(self, "_tunnel_port", None) | ||
| if tunnel_port: | ||
| port = tunnel_port | ||
| # need to override default_port for correct url recording |
Contributor
There was a problem hiding this comment.
I'd suggest changing the url recording logic instead.
Otherwise, looks good to me!
sl0thentr0py
force-pushed
the
neel/stdlib-proxy
branch
2 times, most recently
from
79535e6 to
ea832e5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sl0thentr0py
force-pushed
the
neel/stdlib-proxy
branch
from
ea832e5 to
ae1326b
Compare
sl0thentr0py
force-pushed
the
neel/stdlib-proxy
branch
from
ae1326b to
d8e6104
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| else: | ||
| host = self.host | ||
| port = self.port | ||
|
|
There was a problem hiding this comment.
URL contains :None when tunnel port is unset
Medium Severity
When using a proxy tunnel without specifying a port (set_tunnel(host) or set_tunnel(host, None)), the _tunnel_port attribute is None. The expression port != default_port and ":%s" % port or "" incorrectly evaluates to ":None" because None != 80 is True, and ":%s" % None produces the truthy string ":None". This results in malformed URLs like http://api.example.com:None/foo in span descriptions and data, instead of the expected http://api.example.com/foo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues