-
Notifications
You must be signed in to change notification settings - Fork 116
Improve package:genui pub score. #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Apologies @hunterino, I didn't have permissions to push to your original PR, so I had to create a new one. I'm doing this to preserve the authorship of your commits as much as possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the project's documentation and developer experience by adding a comprehensive set of examples and extensive Dart documentation for various classes and methods. The new examples directory and its detailed README.md are excellent additions. My review includes a couple of suggestions to enhance the clarity of the changelog and the safety of the setup instructions in the example's README.
| /// This class is not meant to be instantiated. | ||
| A2uiSchemas._(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this private constructor? @jacobsimionato
Description
Added some dart documentation and an
exampledirectory to improvepackage:genuipub score.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.