Skip to content

fix: improve ClickHouse connection error handling in state manager #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Savid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve ClickHouse connection error handling in state manager #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pkg/state/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,13 @@ func (s *Manager) getProgressiveNextBlock(ctx context.Context, processor, networ

row := s.storageClient.QueryRow(ctx, s.storageTable, query)
if row == nil {
// ClickHouse client not started, return genesis block
// ClickHouse client not started - this is a connection error, not empty table
s.log.WithFields(logrus.Fields{
"processor": processor,
"network": network,
}).Warn("Storage ClickHouse client not available, starting from genesis block")
}).Error("Storage ClickHouse client not available")

return big.NewInt(0), nil
return nil, fmt.Errorf("storage ClickHouse client not available")
}

err := row.Scan(&blockNumber)
Expand Down Expand Up @@ -296,11 +296,11 @@ func (s *Manager) getProgressiveNextBlockBackwards(ctx context.Context, processo

row := s.storageClient.QueryRow(ctx, s.storageTable, query)
if row == nil {
// ClickHouse client not started, need to find chain tip
// ClickHouse client not started - this is a connection error
s.log.WithFields(logrus.Fields{
"processor": processor,
"network": network,
}).Warn("Storage ClickHouse client not available for backwards mode")
}).Error("Storage ClickHouse client not available for backwards mode")

return nil, fmt.Errorf("storage client not available for backwards processing")
}
Expand Down Expand Up @@ -369,6 +369,12 @@ func (s *Manager) getLimiterMaxBlock(ctx context.Context, network string) (*big.

row := s.limiterClient.QueryRow(ctx, s.limiterTable, query)
if row == nil {
// ClickHouse client not started - this is a connection error
s.log.WithFields(logrus.Fields{
"network": network,
"table": s.limiterTable,
}).Error("Limiter ClickHouse client not available")

return nil, fmt.Errorf("limiter ClickHouse client not available")
}

Expand Down
Loading