refactor(dataset-store): make DatasetKind enum private to crate
#1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate
DatasetKindas a private implementation detail to prevent viral dependencies across the codebase. External crates now useRawDatasetKindwith extractor-specific zero-sized type markers (EvmRpcDatasetKind,SolanaDatasetKind,FirehoseDatasetKind,DerivedDatasetKind) and equality comparisons instead of pattern matching.DatasetKindenumpub(crate)indataset-storeFromStrtoRawDatasetKindfor CLI argument parsingPartialEqimplementations between extractor kinds andRawDatasetKindDatasetKindwithRawDatasetKindin public APIs (error types, handlers)Note
Encapsulates
DatasetKindinside dataset-store and migrates all public-facing APIs toRawDatasetKindwith extractor marker types for comparisons.DatasetKindpub(crate); drop its serde impls/macros and keep local parsing/Display utilitiesFromStrforRawDatasetKindand implementPartialEqbridges withEvmRpcDatasetKind,SolanaDatasetKind,FirehoseDatasetKind,DerivedDatasetKindDatasetKindwithRawDatasetKindacross errors, provider APIs (ProviderInfo), scheduler/worker (JobDescriptor), dump, and controllerampctl manifest generateto acceptRawDatasetKind, branch via marker-type equality, and add Solana generation; update error messagingWritten by Cursor Bugbot for commit d1b17e6. This will update automatically on new commits. Configure here.