Handle peripheral:didModifyServices on corebluetooth #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
added
the
corebluetooth (macos/ios)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the corebluetooth subsystem emits the didModifyServices event the peripheral services become unusable until service discovery is performed again: https://developer.apple.com/documentation/corebluetooth/cbperipheraldelegate/peripheral(_:didmodifyservices:)?language=objc
This PR adds awareness of the didModifyServices event up through to the API layer so that service discovery may be performed again by the user. It also clears discovered services on the corebluetooth platform. While technically only the modified services are unusable after this event, practical testing showed that the peripheral in general is not functional until a full service discovery is performed again.
While adding this support I realized issue: #343 made it impossible to re-discover services without reconnecting to the device. So, this PR also resolves #343 by splitting service discovery off of connection on corebluetooth and moving it to the standalone discover_services() function.