feat: access key custom attributes CRU #746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ test related to descope/etc#13177
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/access_key.py
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom attributes in access key management operations (Create, Read/Search, and Update). The changes enable users to associate custom key-value attributes with access keys and filter by these attributes during search operations.
Changes:
- Added
custom_attributesparameter tocreate,search_all_access_keys, andupdatemethods in the AccessKey management class - Extended search functionality with
bound_user_idandcreating_userfilter parameters - Updated tests to validate the new parameters are correctly passed to the API
- Updated README documentation with examples showing the new parameters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| descope/management/access_key.py | Added custom_attributes parameter to create, search, and update methods; added bound_user_id and creating_user to search method |
| tests/management/test_access_key.py | Updated tests to validate new parameters are correctly serialized and sent to API endpoints |
| README.md | Updated code examples to demonstrate usage of custom_attributes and new search filters |
| .vscode/settings.json | Added workspace color customizations (unrelated to feature) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/descope/etc/issues/13177