Skip to content

Chore: reputation cleanup #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ZocoLini wants to merge 52 commits into
base: refactor/peer-persistence
Choose a base branch
from
Draft

Chore: reputation cleanup #328

ZocoLini wants to merge 52 commits into from

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Dec 30, 2025

The main goal of this PR is to provide a solid start point to move the entire PeerReputationManager to the StorageModule as a PeerReputationStorage.

Based on PR #327

@ZocoLini
the disk storage manager worker is now a time based check, removed ol…
aa0e1ea 
…d command communciation
@ZocoLini
tests updated
a558988
@ZocoLini
thanks coderabbit
0ade0bf
@ZocoLini
merged dev branch
1f168b7
@ZocoLini
removed chain storage an related code
2e85243
@ZocoLini
removed headers from ChainState
3ca55b5
@ZocoLini
tip_height method removed
8f3d065
@ZocoLini
removed get_tip_hesh
53be7f4
@ZocoLini
replaced header_at_height
eb32b7b
@ZocoLini
removed unused methods
2bf3a91
@ZocoLini
init_from_checkpoint sync
f758a7f
@ZocoLini
tip_header removed
f995b89
@ZocoLini
removed two methos that where invovled in the same process
7acccc0
@ZocoLini
fixed ffi
90957cf
@ZocoLini
test updated to the changes
c443764
@ZocoLini
chore: removed fork detector and fork structs (#290)
4be4cef
@ZocoLini
get_header now checks out of bound to return None instead of panics
0e98a8b
@ZocoLini
start height was not being updated properly
06d35e9
@ZocoLini
fixed other test by correctly storing the headers in the storage
abb37f8
@ZocoLini
removed genesis block creation in ChainState creation
4a26a7f
@ZocoLini
fixed clippy warnings
bc544a5
@ZocoLini
Merge branch 'remove-chain-storage' into remove-headers-from-chain-state
0b05253
@ZocoLini
dropped unuseed code
4be7e6e
@ZocoLini
removed filters field from ChainState (ez)
b492b93
@ZocoLini
traits created
90f0b07
@ZocoLini
merged storage worker rework
014baff
@ZocoLini
merged remove-filters-from-chain-state
7f24a22
@ZocoLini
merged remove-headers-from-chain-state
e8ce999
@ZocoLini
everything moved where I want it to be
cac9b29
@ZocoLini
general structure made
8759858
@ZocoLini
persist segments caches now requires the directory where the user wan…
58c29ad 
…ts to write the data
@ZocoLini
using rwlock to allow segmentcache mutability behind inmutable ref
c809c1f
@ZocoLini
clear method fixed
0bf4407
@ZocoLini
default method implementations in storage traits
3a9e273
@ZocoLini
storage manager trait implemented
f40a2bd
@ZocoLini
fixed code to pass the tests
8a542f0
@ZocoLini
storage documentation updated
2bc0490
@ZocoLini
peers persistance moved to the storage module
cfb0cab
@ZocoLini
peers reputations storage system moven to the storage module
e5c81d0
@ZocoLini
peer storage cleanup
3c95a98
@ZocoLini
peer reputation deserialization values clamp moved into serde pipeline
2d4550e
@ZocoLini
tests corrrectly use a temp dir
a1417c2
@ZocoLini
clippy warning fixed
2e62376
@ZocoLini
gitignore updated
3ca989d
@ZocoLini
removed Arc<RwLock<>> from PeerReputationManager
8776716
@ZocoLini
removed unused fields in PeerReputationManager
9c06cc3
@ZocoLini
removed unused stuff after making the reputation module private
fa6593a
@ZocoLini
visibility and removal of redundant code
e6cdeff
@ZocoLini
ReputationChangeReason replacing old constant values
923712a
@ZocoLini
positive and negative4 action fields removed
4cd7ba9
@ZocoLini
connection stats removed from PeerReputation
c56321e
@ZocoLini
PeerReputationManager always tries to load in the constructor
78a5600
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini marked this pull request as draft December 30, 2025 22:26
@ZocoLini ZocoLini force-pushed the refactor/peer-persistence branch from 3ca989d to 4a7925a Compare January 8, 2026 21:54
@github-actions github-actions bot added the merge-conflict The PR conflicts with the target branch. label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

@ZocoLini ZocoLini force-pushed the refactor/peer-persistence branch from b5acafb to efa632e Compare January 22, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merge-conflict The PR conflicts with the target branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZocoLini