Issue 44 add embellishments to the first two sections of the landing page #59
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f_the_landing_page' of https://github.com/codersforcauses/game-dev into issue-44-Add_embellishments_to_the_first_two_sections_of_the_landing_page
…hments_to_the_first_two_sections_of_the_landing_page
laurenpudz
requested review from
SafetyInObscurity,
laurenpudz and
samjjacko
and removed request for
SafetyInObscurity and
laurenpudz
laurenpudz
requested changes
Jan 24, 2026
| width={600} | ||
| height={430} | ||
| alt="placeholder" | ||
| className="min-w-[360px] rounded-md border-[26px] border-accent [clip-path:polygon(20px_20px,calc(100%-20px)_20px,100%_32px,100%_30%,calc(100%-20px)_45%,calc(100%-20px)_calc(100%-8px),80%_calc(100%-8px),75%_calc(100%-20px),20px_calc(100%-20px),0%_60%,0%_30%,20px_25%)]" |
Contributor
There was a problem hiding this comment.
do you need specifically 360px here for min-w and 26px for the border? If so, all g, if not, try using one of the predefined tailwind classes. Also do you still need the rounded-md class here? It can probs be deleted now
| return ( | ||
| <> | ||
| <header className="z-100 sticky top-0 flex h-24 w-full flex-wrap items-center justify-center rounded-md border-b border-border/20 bg-background px-20 font-jersey10"> | ||
| <header className="sticky top-0 z-10 flex h-24 w-full flex-wrap items-center justify-center rounded-md border-b border-border/20 bg-background px-20 font-jersey10"> |
Contributor
There was a problem hiding this comment.
why is this being changed?
| width={96} | ||
| height={156} | ||
| alt="placeholder" | ||
| className="absolute bottom-0 left-0 h-auto w-[20%] -translate-x-1/4 -translate-y-4 rounded-md [image-rendering:pixelated]" |
Contributor
There was a problem hiding this comment.
why is the rounded-md class here?
| </section> | ||
|
|
||
| <section className="bg-dark_3 py-16"> | ||
| <section className="-m-8 bg-dark_3 py-16 [clip-path:polygon(0%_0%,20%_0%,calc(20%+32px)_32px,100%_32px,100%_100%,0%_100%)] [overflow:clip]"> |
Contributor
There was a problem hiding this comment.
the -m-8 here also affects the horizontal margins of the section. Is there a way to only apply this at the top?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added embellishments to first two sections of landing page
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Related issue