-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 49 games showcase page #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…dersforcauses/game-dev into issue-7-Individual_game_pages This because my branch and the 'origin/issue-7-Individual_game_pages' have diverged
…dersforcauses/game-dev into issue-7-Individual_game_pages Fixed issue with the server side models.py, migrated the two new models games and events
…ternal image domains for better asset management
….io account the value is added
…ignment and spacing
…dersforcauses/game-dev into issue-7-Individual_game_pages-backend Pulling any changes from issue-7-Individual_game_pages
…ages-backend Add backend changes of Itch Emed
…g and layout responsive
… field and upload location, events foregein key can be empty or set to empty if event is removed, if isItch is true then hostURL is itch.io game id 7 digit
…, contributors, and embed Itch.io game
…st ItchEmbed component styling
…dering and improve component structure
…e Games via /admin/
…ness and update component structure
…tor and add migration for renaming
…t was overwritten with the itchEmbedID. Updated the database schema to have both hostURL and itchEmbedID so that both the Host Site field on the page and the itch embed both work.
…ing and improve loading/error handling
| COMPLETED = 4, "Completed" | ||
|
|
||
| name = models.CharField(max_length=200, null=False) | ||
| description = models.TextField() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A large enough char field here will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be a suitable length for the description? There were plans to potentially implement markdown support for the description, and some of the descriptions from itch.io are over 1000 characters.
Would the game dev site be using descriptions similar to itch.io, or is the intention for these descriptions to be limited to shorter (with full description on itch or host site if applicable)? If using descriptions similar to those on itch, perhaps a ~2000 character length would be suitable.
…ditional for whether ItchEmbed widget is used. Updated help text for itchEmbedID to remove the "7 digit" descriptor as length is 1+ digits depending on game.
…eld instead of CharField.
…ersforcauses/game-dev into issue-49-Games_Showcase_Page
…ersforcauses/game-dev into issue-49-Games_Showcase_Page
Change Summary
Add games showcase page, frontend and backend

Issue #49
Frontend URL: http://localhost:3000/games
Backend API URL: http://localhost:8000/api/gameshowcase/
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Test procedure:
Add new or exisitng games to game showcase in the admin panel, remember to include contributor and role when add the games
Known issues:
Social media link not working because of member model is not ready.
Related issue