Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 16, 2026

Related: #1197

This PR includes:

  • adding NodeJSProfiler class
  • implemented performanceObserver for NodeJSProfiler
  • revamp PerformanceObserverSink - add getStatus for better testing, more robust and memory friendly buffer logic

- Add explanation that sink determines output format (DevTools TraceEvent, OpenTelemetry, etc.)
- Improve documentation clarity for flexible serialization capabilities
- Fix duplicate imports in profiler unit test
- Replace method implementations with vi.fn() spy functions
- Add vi import from vitest
- Enables better testing with call tracking and assertions
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels Jan 16, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2026

View your CI Pipeline Execution ↗ for commit 8334310

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 27s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 47s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 8s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-18 17:55:46 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 16, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1219

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1219

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1219

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1219

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1219

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1219

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1219

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1219

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1219

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1219

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1219

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1219

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1219

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1219

commit: 8334310

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf3e48b with previous commit 270b474.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 42 🟡 50 ↑ +8.2
Performance 🔴 37 🔴 35 ↓ −1.8
Code coverage 🟢 93 🟢 93 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 1 group regressed, 👍 9 audits improved, 👎 3 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 42 🟡 50 ↑ +8.2
Lighthouse Performance 🔴 37 🔴 35 ↓ −1.8
Code coverage Code coverage metrics 🟢 93 🟢 93 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Properties coverage 🟥 30 undocumented properties 🟥 26 undocumented properties ↓ −13.3 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 9 undocumented methods ↓ −30.8 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟨 5 undocumented classes ↓ −16.7 %
Lighthouse Speed Index 🟥 6.0 s 🟥 6.5 s ↑ +8.4 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.3 s ↑ +7.3 %
Lighthouse Total Blocking Time 🟥 1,890 ms 🟥 1,920 ms ↑ +1.9 %
JSDocs coverage Variables coverage 🟥 268 undocumented variables 🟥 267 undocumented variables ↓ −0.4 %
JSDocs coverage Types coverage 🟥 268 undocumented types 🟥 267 undocumented types ↓ −0.4 %
JSDocs coverage Functions coverage 🟥 577 undocumented functions 🟥 577 undocumented functions  +0 %
Code coverage Line coverage 🟩 92.7 % 🟩 92.8 % ↑ +0.1 %
Code coverage Function coverage 🟩 94.4 % 🟩 94.4 % ↑ +0.1 %
Code coverage Branch coverage 🟨 89 % 🟨 89.1 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,104 KiB 🟩 Total size was 2,106 KiB ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 9.2 s 🟥 8.9 s ↓ −3.5 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 224 KiB 🟥 Potential savings of 225 KiB ↓ −19.7 %
Lighthouse JavaScript execution time 🟥 4.3 s 🟥 4.4 s ↑ +3.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −23 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 1,200 ms 🟩 1,140 ms ↓ −5.1 %
Lighthouse Max Potential First Input Delay 🟥 980 ms 🟥 930 ms ↓ −5.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 60 ms ↑ +673.5 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 490 ms ↓ −8.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.2 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 13.0 s ↓ −0.2 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.5 s ↓ −0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 93 KiB 🟥 Potential savings of 93 KiB ↑ +2.2 %

653 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review January 16, 2026 22:22
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Code PushUp

🥳 Code PushUp report has improved – compared current commit bf3e48b with previous commit 270b474.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 45 🟡 56 ↑ +10.7
Code coverage 🟢 95 🟢 95 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 9 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 45 🟡 56 ↑ +10.7
Code coverage Code coverage metrics 🟢 95 🟢 95 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Properties coverage 🟥 27 undocumented properties 🟥 23 undocumented properties ↓ −14.8 %
JSDocs coverage Classes coverage 🟨 3 undocumented classes 🟨 2 undocumented classes ↓ −33.3 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 9 undocumented methods ↓ −30.8 %
JSDocs coverage Variables coverage 🟥 49 undocumented variables 🟥 48 undocumented variables ↓ −2 %
JSDocs coverage Types coverage 🟥 66 undocumented types 🟥 65 undocumented types ↓ −1.5 %
JSDocs coverage Functions coverage 🟥 239 undocumented functions 🟥 239 undocumented functions  +0 %
Code coverage Line coverage 🟩 97.8 % 🟩 97.9 % ↑ +0.1 %
Code coverage Function coverage 🟩 96.2 % 🟩 96.3 % ↑ +0.1 %
Code coverage Branch coverage 🟩 91.8 % 🟩 91.9 % ↑ +0.1 %

435 other audits are unchanged.


13 other projects are unchanged.

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
@BioPhoton BioPhoton requested a review from hanna-skryl January 18, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants