Skip to content

Conversation

@ImSingee
Copy link

Some extensions' name contain _, such as pg_ivm, pg_textsearch. Tests will fail on these extensions because this name violates k8s name's rule.

This PR fixes this by generating a k8s_name field in values.yaml and use this name as all k8s resource names.

Signed-off-by: Bryan <git@singee.me>
@ImSingee
Copy link
Author

Another thing I found when working on this PR: There's a e2e:test:all task available, but it executes e2e:test. However, the e2e:test task requires values.yaml file available for each target (which can be generated by e2e:generate-values). But currently there's no way to generate values file for all targets.

I think update e2e:test:all task's behaviour to execute e2e:test:all is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant