ENT-9962: adds optionality args getusers() and getgroups() + tests #6022
+135
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonThalvorsen
force-pushed
the
ENT-9962
branch
from
1c1dcb8 to
36aaa88
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SimonThalvorsen
force-pushed
the
ENT-9962
branch
from
36aaa88 to
6fe5f96
Compare
larsewi
requested changes
Jan 19, 2026
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Looks great 🚀 Some smaller comments
SimonThalvorsen
force-pushed
the
ENT-9962
branch
from
6fe5f96 to
60149cc
Compare
This is now allowed: "users" slist => getusers(); "users" slist => getusers( "filtered,usernames" ); "users" slist => getusers( "filtered,usernames", "filtered,ids" ); Ticket: ENT-9962 Changelog: Adds optionality to the arguments in the getusers()-function. Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
This is now allowed:
"groups" slist => getgroups();
"groups" slist => getgroups( "filtered,groups" );
"groups" slist => getgroups( "filtered,groups", "filtered,ids" );
Ticket: ENT-9962
Changelog: Adds optionality to arguments in the getgroups()-function
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-9962
branch
from
60149cc to
67cd35e
Compare
larsewi
approved these changes
Jan 19, 2026
Contributor
Author
|
@cf-bottom Heyo, jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13325/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13325/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.