Skip to content

Relax project msrv; CI test on msrv, stable, and nightly #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchickey merged 5 commits into from
Jan 16, 2026
Merged

Relax project msrv; CI test on msrv, stable, and nightly #118

pchickey merged 5 commits into from
Jan 16, 2026

Conversation

@pchickey
Copy link
Contributor

@pchickey pchickey commented Jan 15, 2026 •
edited
Loading

  • wstd's msrv is now backed up by 1 to 1.88, which is the aws sdk's current msrv, in preparation of upstreaming wstd-aws as part of the official distribution.
  • Backing off to 1.88 required one minor change in test-programs to take a dep for a not-yet-stabilized locking method on files. Backing off to 1.87 would require minor syntactical changes in wstd itself, which of course is possible, but I'm not motivated to keep going backwards for things like that unless we have a use case that requires it
  • the install rust action had a bug in the sed for parsing msrv, which is now fixed
  • CI was testing a matrix of host OSs, but just stable rust. I don't feel strongly that we need to test on a matrix of host OSs since wasmtime is taking care of cross-OS compatibility, so I eliminated that dimension of the matrix, and I made the matrix test msrv, stable, and nightly rust. If nightly breaks we can pin it to an older nightly or eliminate that column.

@pchickey
back msrv off to 1.88
fbd28b3
@pchickey
ci: matrix build on msrv, stable, nightly
9aaf79f
@pchickey
ci: no need to matrix on host os
3857d71 
this is entirely cross-compiled. Duplicating testing on multiple OSs
takes a bunch of time and is what the wasmtime project is supposed to do
so we don't have to. If we regret this later its not hard to re-enable,
but for now it doesn't seem warranted
@pchickey
install-rust action: fix msrv sed
a2c1f2e
@pchickey
test programs: compat with 1.88
e834380
@pchickey pchickey requested a review from cfallin January 16, 2026 00:10
@pchickey pchickey merged commit 67939b3 into main Jan 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfallin cfallin cfallin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pchickey @cfallin