Add EINVAL to TCGETS2/TCSETS2 fallback triggers #1573
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
EINVALto the error codes that trigger fallback fromTCGETS2/TCSETS2to the legacyTCGETS/TCSETSioctls.Motivation
Some emulated and virtualized environments don't implement
TCGETS2/TCSETS2and returnEINVALrather thanENOTTYorEACCES. This includes CheerpX/WebVM (x86-to-WebAssembly virtualization in the browser).The fallback logic already exists for
ENOTTYandEACCES. This change simply addsEINVALas another trigger.Reproducing
cargo build --target i686-unknown-linux-musl --release -F termios,ptyRunning on https://webvm.io/ outputs:
With this change, the fallback to
TCGETSsucceeds.Changes
tcgetattr: addErrno::INVALto fallback match armtcsetattr: addErrno::INVALto fallback match arm