test: Fix bib test failure and add required package in bib test #1944
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: cannot build manifest: no default fs set: mount "/boot" requires a filesystem but none set Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a test failure in the bib-build test. The changes are twofold: first, it adds the qemu-img package to hack/packages.txt, which is a necessary dependency for the test. Second, it modifies the podman run command in tmt/tests/booted/test-bib-build.nu to include the --rootfs xfs argument, which explicitly sets the root filesystem type and resolves the error cannot build manifest: no default fs set. Both changes are correct and directly address the issues described. The PR is well-focused and looks good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bib test failure with
error: cannot build manifest: no default fs set: mount "/boot" requires a filesystem but none set.Add bib test required package
qemu-imgintopackages.txt.