fix: remove parse_trans from runtime dependencies (#714) #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_trans provides ct_expand which is only used at compile time for evaluating cipher suites and decoding CA certificates. The results are baked into the .beam files at compile time, so parse_trans is not needed at runtime. This reduces the runtime dependency chain, particularly helping users with environments that don't include syntax_tools (like elixir-desktop).
benoitc
force-pushed
the
fix/parse-trans-runtime
branch
from
abdec26 to
1faf2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parse_transfrom theapplicationslist inhackney.app.srcparse_transprovidesct_expandwhich is only used at compile time (for computing cipher suites and decoding CA certificates).beamfiles at compile time, soparse_transis not needed at runtimeThis reduces the runtime dependency chain:
hackney→parse_trans→syntax_toolsParticularly helpful for environments without
syntax_tools(e.g., elixir-desktop).Closes #714