Fix pretty_format failure under set -o pipefail #140
Merged
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously pretty_format used a conditional with &&. When the caller had pipefail enabled and alt_symbol was empty, the conditional could return a non-zero status and cause the whole pipeline to fail. This change prevents false failures when running tests with pipefail enabled.
Member
|
Thanks @aarvio great fix! I just updated doc to match with the new test you introduced as doc is automatically checked against the code. |
Author
|
Thanks. And sorry for neglecting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pretty_format used a conditional with &&. When the caller had pipefail enabled and alt_symbol was empty, the conditional could return a non-zero status and cause the whole pipeline to fail.
This change prevents false failures when running tests with pipefail enabled.