-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: show id in content #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
packages/core/database/migrations/2026_01_19_000000_add_id_to_content_table.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
packages/core/database/migrations/2026_01_19_000000_add_id_to_content_table.php
Show resolved
Hide resolved
… into feat/show-id-in-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }); | ||
|
|
||
| // Use raw SQL to set auto-increment (Laravel's autoIncrement() tries to make it primary) | ||
| DB::statement('ALTER TABLE content MODIFY id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration uses MySQL-specific SQL syntax
Medium Severity
The migration uses MySQL-specific syntax that will fail on PostgreSQL, SQLite, and SQL Server. The SET @row_number = 0 user-defined variables, the := assignment operator in the UPDATE statement, and the MODIFY keyword in ALTER TABLE are all MySQL-only features. Running this migration on any non-MySQL database will result in a failure.
| { | ||
| return $table | ||
| ->columns([ | ||
| TextColumn::make('id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID column missing from database view table
Low Severity
The new ID column was added to the table() method but not to tableDatabase(). Both methods render content listings, but only table() respects the show_id_in_content_overview config. When users view content filtered by type (using the "Database" view in ListContent.php), the ID column won't appear even when the config is enabled, creating an inconsistent user experience.
Note
Adds a numeric identifier to content and makes it optionally visible in the CMS list.
idtocontent, backfills existing rows increated_atorder, and enforces uniquenessContentResourcetable includes a sortable/searchableidcolumn, visibility controlled byconfig('backstage.cms.show_id_in_content_overview')config/backstage/cms.php) introducesshow_id_in_content_overviewflag (defaultfalse)Written by Cursor Bugbot for commit 9f1d89b. This will update automatically on new commits. Configure here.