chore(ci): update layer script to include event-handler #4956
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dreamorosi
requested changes
Jan 19, 2026
Contributor
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
Thanks for the PR.
It's not a one-liner, or I'd have done it right away.
We also need to come up with some kind of test case to be added here to make sure it doesn't break the layer.
Contributor
Author
|
Ah I see. And it's a sort of chicken and egg situation cos you can't test it until the code is in the layer. |
Contributor
No, the test builds the layer with whatever is in the build script you modified before running - that's the point of that canary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The event-handler package is not included in the script that builds our lambda layers so we need to add it.
Changes
layers/src/layer-publisher-stack.tsscript to include the event-handler packageIssue number: closes #4955
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.