SOLR-7003: mark method as deprecated for branch_10x #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
reviewed
Jan 18, 2026
Comment on lines
+509
to
+510
| * @deprecated The waitFlush parameter has no actual effect on the server side and is removed in | ||
| * Solr 11. |
Contributor
There was a problem hiding this comment.
That's a confusing statement; it's ambiguous wether it has an effect in Solr 10. Lets not refer to Solr 11. It probably never worked ever.
Contributor
Author
|
i think I need to deprecate CommitStream use of waitFlush as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-7003
Mark method with non functioning waitFlush as deprecated. This will go to Solr 10. The related PR #4058 will remove this from Solr 11.