perf: remove unnecessary string clone in maybe_concat_string_literal #2173
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove an unnecessary
String::clone()inmaybe_concat_string_literal().Changes
Since
sis already a&String(from theref spattern match), it can be passed directly topush_str()which accepts&str. The deref coercion handles the conversion automatically.Impact
This removes one heap allocation per concatenated string literal when parsing SQL with adjacent string literals like:
Small change but in the spirit of avoiding unnecessary allocations in the parser hot path.
Test plan
cargo clippypasses🤖 Generated with Claude Code