Skip to content

fix(@angular/cli): Remove nonexistent link from MCP response #32318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amishne wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(@angular/cli): Remove nonexistent link from MCP response #32318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular/cli/src/commands/mcp/tools/modernize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ export async function runModernization(input: ModernizeInput, host: Host) {
if (transformationNames.length === 0) {
return createStructuredContentOutput({
instructions: [
'See https://angular.dev/best-practices for Angular best practices. ' +
'You can call this tool if you have specific transformation you want to run.',
'Call this tool with the specific transformations you want to run. See the tool description for more info. Also call the' +
' `get_best_practices` tool for general Angular best practices.',
],
});
}
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/cli/src/commands/mcp/tools/modernize_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ describe('Modernize Tool', () => {

expect(mockHost.runCommand).not.toHaveBeenCalled();
expect(structuredContent?.instructions).toEqual([
'See https://angular.dev/best-practices for Angular best practices. ' +
'You can call this tool if you have specific transformation you want to run.',
'Call this tool with the specific transformations you want to run. See the tool description for more info. Also call the' +
' `get_best_practices` tool for general Angular best practices.',
]);
});

Expand Down