refactor(@angular-devkit/schematics): support isolatedDeclarations for tree classes
#32315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for tree classes This commit refactors several Tree implementations (`DelegateTree`, `HostTree`, `NullTree`, `ScopedTree`) to support the TypeScript `isolatedDeclarations` compiler option. It uses declaration merging to define the `[TreeSymbol]` method on an interface and assigns it in the constructor to avoid TS9038 errors regarding computed property names inference.
clydin
force-pushed
the
isolated-declarations-5
branch
from
d20da4b to
8e32605
Compare
clydin
force-pushed
the
isolated-declarations-5
branch
from
e6e8d56 to
8e32605
Compare
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors several Tree implementations (
DelegateTree,HostTree,NullTree,ScopedTree) to support the TypeScriptisolatedDeclarationscompiler option. It uses declaration merging to define the[TreeSymbol]method on an interface and assigns it in the constructor to avoid TS9038 errors regarding computed property names inference.