Skip to content

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 19, 2026

Description

This PR is addressing some of the UI issues that design team reported to input system.
Align title font size with toolbar style in Input Action window.

Toolbar use toolbar style:
- The font is regular (12pt)
- Height is 20px

Before:
Screenshot 2026-01-20 at 12 00 40

After:
Screenshot 2026-01-19 at 14 24 24

JIRA: https://jira.unity3d.com/browse/ISX-2340

Testing status & QA

No testing is needed.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 19, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title Update InputActionsEditor.uxml FIX: Align title font size with toolbar style in Input Action window Jan 20, 2026
@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review January 20, 2026 12:25
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 20, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

ISX-2340 - Partially compliant

Compliant requirements:

  • Toolbar should use toolbar style (font regular 12pt; height 20px)

Non-compliant requirements:

  • Fix Auto-Save toggle padding/inline styles (width/padding/label min-width)
  • Add “Shadow” section headers (component-like headers that allow buttons)
  • “Add” buttons should use add icon / add more icon where appropriate
  • Action properties should use reorderable lists
  • Consider a single helpbox to explain default setting

Requires further human verification:

  • Toolbar-style alignment visually matches other Editor toolbars across light/dark themes and at non-100% UI scaling
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

Small, localized UI markup changes with low behavioral risk, but needs quick visual validation across themes/scaling.
🏅 Score: 84

The change is straightforward and likely fixes the reported sizing inconsistency, but relies on repeated inline styles that may not scale well across Editor UI settings.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Maintainability

New font/height values are applied via repeated inline style on multiple headers/labels; consider moving these to a shared USS rule/class (or reusing an existing toolbar/header class) to avoid drift and make future UI tweaks easier.

    <ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;">
        <ui:Label text="Action Maps" display-tooltip-when-elided="true" style="flex-grow: 1; font-size: 12px;"/>
        <ui:Button display-tooltip-when-elided="true" name="add-new-action-map-button" style="align-items: auto;"/>
    </ui:VisualElement>
    <ui:VisualElement name="body">
        <ui:ListView focusable="true" name="action-maps-list-view"/>
    </ui:VisualElement>
    <ui:VisualElement name="rclick-area-to-add-new-action-map" style="flex-direction: column; flex-grow: 1;"/>
</ui:VisualElement>
<ui:TwoPaneSplitView name="actions-and-properties-split-view" fixed-pane-index="1" fixed-pane-initial-dimension="320" view-data-key="actions-editor-splitter-2" style="height: auto; min-width: 450px;">
    <ui:VisualElement name="actions-container" class="body-panel-container">
        <ui:VisualElement name="header" class="body-panel-header" style="justify-content: space-between; font-size: 12px; height: 20px; min-height: 20px;">
            <ui:Label text="Actions" display-tooltip-when-elided="true" name="actions-label" style="font-size: 12px;"/>
            <ui:Button display-tooltip-when-elided="true" name="add-new-action-button" style="align-items: auto;"/>
        </ui:VisualElement>
        <ui:VisualElement name="body">
            <ui:TreeView view-data-key="unity-tree-view" focusable="true" name="actions-tree-view" show-border="false" reorderable="true" show-alternating-row-backgrounds="None" fixed-item-height="20"/>
        </ui:VisualElement>
        <ui:VisualElement name="rclick-area-to-add-new-action" style="flex-direction: column; flex-grow: 1;"/>
    </ui:VisualElement>
    <ui:VisualElement name="properties-container" class="body-panel-container body-panel-container" style="min-width: 310px;">
        <ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;">
            <ui:Label text="Action Properties" display-tooltip-when-elided="true" name="properties-header-label" style="font-size: 12px;"/>
        </ui:VisualElement>
UI Scaling Risk

Hard-coded height: 20px / min-height: 20px combined with font-size: 12px may clip or misalign content under different Editor UI scaling/DPI or font settings; verify layout in common scaling settings and ensure buttons/labels remain vertically centered.

    <ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;">
        <ui:Label text="Action Maps" display-tooltip-when-elided="true" style="flex-grow: 1; font-size: 12px;"/>
        <ui:Button display-tooltip-when-elided="true" name="add-new-action-map-button" style="align-items: auto;"/>
    </ui:VisualElement>
    <ui:VisualElement name="body">
        <ui:ListView focusable="true" name="action-maps-list-view"/>
    </ui:VisualElement>
    <ui:VisualElement name="rclick-area-to-add-new-action-map" style="flex-direction: column; flex-grow: 1;"/>
</ui:VisualElement>
<ui:TwoPaneSplitView name="actions-and-properties-split-view" fixed-pane-index="1" fixed-pane-initial-dimension="320" view-data-key="actions-editor-splitter-2" style="height: auto; min-width: 450px;">
    <ui:VisualElement name="actions-container" class="body-panel-container">
        <ui:VisualElement name="header" class="body-panel-header" style="justify-content: space-between; font-size: 12px; height: 20px; min-height: 20px;">
            <ui:Label text="Actions" display-tooltip-when-elided="true" name="actions-label" style="font-size: 12px;"/>
            <ui:Button display-tooltip-when-elided="true" name="add-new-action-button" style="align-items: auto;"/>
        </ui:VisualElement>
        <ui:VisualElement name="body">
            <ui:TreeView view-data-key="unity-tree-view" focusable="true" name="actions-tree-view" show-border="false" reorderable="true" show-alternating-row-backgrounds="None" fixed-item-height="20"/>
        </ui:VisualElement>
        <ui:VisualElement name="rclick-area-to-add-new-action" style="flex-direction: column; flex-grow: 1;"/>
    </ui:VisualElement>
    <ui:VisualElement name="properties-container" class="body-panel-container body-panel-container" style="min-width: 310px;">
        <ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;">
            <ui:Label text="Action Properties" display-tooltip-when-elided="true" name="properties-header-label" style="font-size: 12px;"/>
        </ui:VisualElement>
Changelog Style

The new entry reads as a fragment; consider matching the existing “Fixed …” phrasing for consistency with nearby entries in the Fixed section.

- Align title font size with toolbar style in `Input Action` window.
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 20, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 20, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2328   +/-   ##
========================================
  Coverage    77.95%   77.95%           
========================================
  Files          476      476           
  Lines        97453    97466   +13     
========================================
+ Hits         75971    75982   +11     
- Misses       21482    21484    +2     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_2022.3_project 75.47% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.28% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.17% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.18% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.5 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.18% <ø> (+<0.01%) ⬆️
inputsystem_Windows_2022.3 5.54% <ø> (+<0.01%) ⬆️
inputsystem_Windows_2022.3_project 75.60% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.49% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 77.50% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

<ui:VisualElement name="action-maps-container" class="body-panel-container actions-container">
<ui:VisualElement name="header" class="body-panel-header">
<ui:Label text="Action Maps" display-tooltip-when-elided="true" style="flex-grow: 1;"/>
<ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this kind of information would better suit a uss file instead (to keep structure separate from visuals), but not sure we have uss for this particular section here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if we indeed have styles for it please?

Copy link
Collaborator

@K-Tone K-Tone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question regarding styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants