-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Align title font size with toolbar style in Input Action window #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FIX: Align title font size with toolbar style in Input Action window #2328
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2328 +/- ##
========================================
Coverage 77.95% 77.95%
========================================
Files 476 476
Lines 97453 97466 +13
========================================
+ Hits 75971 75982 +11
- Misses 21482 21484 +2 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| <ui:VisualElement name="action-maps-container" class="body-panel-container actions-container"> | ||
| <ui:VisualElement name="header" class="body-panel-header"> | ||
| <ui:Label text="Action Maps" display-tooltip-when-elided="true" style="flex-grow: 1;"/> | ||
| <ui:VisualElement name="header" class="body-panel-header" style="font-size: 12px; height: 20px; min-height: 20px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this kind of information would better suit a uss file instead (to keep structure separate from visuals), but not sure we have uss for this particular section here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if we indeed have styles for it please?
K-Tone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question regarding styles
Description
This PR is addressing some of the UI issues that design team reported to input system.
Align title font size with toolbar style in Input Action window.
Before:

After:

JIRA: https://jira.unity3d.com/browse/ISX-2340
Testing status & QA
No testing is needed.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.