feat(DynamicVoiceChat): implement main logic #1370

christolis · 2026-01-04T00:31:29Z

Closes #1113.

Showcase

Screen.Recording.2026-01-04.at.02.35.21.mov

Configuration changes

Property	Description	Type
`dynamicVoiceChannelPatterns`	List of voice channel patterns to manage dynamically.	List[String]

Co-authored-by: Suraj Kumar <76599223+surajkumar@users.noreply.github.com> Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Using 'Logger#info' is too spammy in the console, use 'Logger#trace' instead. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

tj-wazei

Happy with this and have tested.

SquidXTV · 2026-01-05T14:29:18Z

application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java

+        channel.delete()
+            .queue(_ -> logger.trace("Deleted dynamically created voice channel: {} ",
+                    channel.getName()),
+                    error -> logger.error("Failed to delete dynamically created voice channel: {} ",
+                            channel.getName(), error));
+    }


I think I would kinda prefer if this workflow will post a warning in the voice channel chat with a specific timer for deletion (30sec) or whatever, then checking again for memberCount == 0 and then actually deleting or otherwise stopping the workflow

I thought about this when reviewing and decided to skip past a timer. There is a message sent when the channel is created and there's really no need to keep the channel longer. It can be recreated right away anyway.

Having said this, I am now thinking about moderation...

Temp voice chat -> users posting nonsense -> evidence deleted ...?

Perhaps instead of deleting the channel, we can move it to a private/mod-only voice-chat-archive channel so only we can still check chats. Followed by a daily clean up task.

What do you think?

That sounds great, we need to keep track of what people post in these ephemeral channels. Perhaps instead of deleting, send a log of all the messages sent as one embed.

You'll hit the character limit very quickly with an embed. It's best to just hide the channel so only moderators can see this and clean up after some time period.

I would say it is best if we keep it as it is now and add such functionality later on

I will try to push a temporary solution today so that moderation is still possible with these ephemeral voice channels. Feel free to resolve this thread once you are fine with the pushed implementation.

Zachdehooge · 2026-01-11T16:45:23Z

Would love to carry this feature forward, got permission from @christolis

Zachdehooge · 2026-01-11T17:40:02Z

Just some things to note:

"Support/Studying Room" with no numbers produces the desired result of TJ creating a temp channel for the user and deleting it when everyone leaves the channel.

"Support/Studying Room" with any number after it (1,2,3,4) does not produce a temp channel, and the channel itself it deleted after everyone leaves the channel.

This brings me to the question of when this gets implemented, will we have only one channel, "Support/Studying Room", with no numbers? If so, this does not need to be addressed. If there will still be 4 different studying channels as it is currently, this is something that will need to be handled. Just wanted to confirm before tackling that, since it's not really an issue per se if the channel is just "Support/Studying Room" with no numbers

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Currently there is no way to moderate ephemeral voice channels. Members could very easily break the rules in the channel, send NSFW content and it can go undetected by the moderation team. Introduce a new archival system where the ephemeral voice channels are instead stored in an archival category. Depending on the archival strategy, channels are removed once they are not needed any more. Routines are not being used since we are able to get away with attempting cleanup every time a user leaves an ephemeral voice channel. This results in superior performance and no scheduling involved. Do _not_ archive ephemeral voice channels with no contents sent by members. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

christolis · 2026-01-20T12:19:25Z

@Zachdehooge I apologize for not responding to your question promptly.

On 1/11/26 19:40, Zach wrote: Zachdehooge left a comment (Together-Java/TJ-Bot#1370) This brings me to the question of when this gets implemented, will we have only one channel, "Support/Studying Room", with no numbers? If so, this does not need to be addressed.

I assume that this is going to be the case. It will need to be handled by an authorized member of our community to update the channels appropriately though.

Just wanted to confirm before tackling that

Absolutely, and thank you for asking that :)

This is why breaks are important, I committed my previous changes while being hungry... Set realistic constant values for CLEAN_CHANNELS_AMOUNT and MINIMUM_CHANNELS_AMOUNT so that more channels are kept in the archive. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

SquidXTV · 2026-01-20T17:06:33Z

application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java

+            messageHistory.retrievePast(2).queue(messages -> {
+                // Don't forget that there is always one
+                // embed message sent by the bot every time.
+                if (messages.size() > 1) {
+                    archiveDynamicVoiceChannel(channelLeft);
+                } else {
+                    channelLeft.delete().queue();
+                }
+            });


Can't you simply use MessageHistory#size instead?

In order to make use of MessageHistory#size, a method like MessageHistory#retrievePast needs to be invoked first because otherwise the size method will always return 0 regardless of the channel's history.

tj-wazei · 2026-01-20T18:06:37Z

application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java

+public final class DynamicVoiceChat extends VoiceReceiverAdapter {
+    private static final Logger logger = LoggerFactory.getLogger(DynamicVoiceChat.class);
+
+    // @christolis: Unless somebody is willing to make the category name configurable,


Please remove the comment and adds these configurations into the config file. Thanks

The constant name is self-documenting. If someone wants to make it as well as other constants in this class configurable later, they can submit a pull request with _actual reasoning_ instead of bikeshedding over a defensive comment. The constant is hardcoded because it's _unlikely_ anyone will want to change it. If that assumption proves wrong, it's trivial to refactor. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

feat(DynamicVoiceChat): implement main logic

41a827f

Co-authored-by: Suraj Kumar <76599223+surajkumar@users.noreply.github.com> Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

christolis requested a review from a team as a code owner January 4, 2026 00:31

christolis marked this pull request as draft January 4, 2026 00:31

christolis added 3 commits January 4, 2026 02:40

DynamicVoiceChat.java: use trace instead of info

cabd30a

Using 'Logger#info' is too spammy in the console, use 'Logger#trace' instead. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

DynamicVoiceChat.java: more trace instead of info

42d61f6

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Make class final and add JavaDoc

e93861d

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

christolis added config-changes if your PR contains any changes related to config file java Pull requests that update java code enhancement New feature or request labels Jan 4, 2026

christolis marked this pull request as ready for review January 4, 2026 11:09

tj-wazei previously approved these changes Jan 4, 2026

View reviewed changes

SquidXTV reviewed Jan 5, 2026

View reviewed changes

tj-wazei self-requested a review January 5, 2026 15:50

christolis assigned Zachdehooge Jan 11, 2026

Resolve merge conflicts

2679a2f

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

christolis dismissed tj-wazei’s stale review via 2679a2f January 19, 2026 15:29

christolis requested a review from SquidXTV January 20, 2026 12:01

SquidXTV reviewed Jan 20, 2026

View reviewed changes

SquidXTV previously approved these changes Jan 20, 2026

View reviewed changes

tj-wazei requested changes Jan 20, 2026

View reviewed changes

christolis dismissed SquidXTV’s stale review via 3ba0b7a January 20, 2026 19:31

Uh oh!

feat(DynamicVoiceChat): implement main logic #1370

Are you sure you want to change the base?

feat(DynamicVoiceChat): implement main logic #1370

Uh oh!

Conversation

christolis commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Showcase

Configuration changes

Uh oh!

tj-wazei left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zachdehooge commented Jan 11, 2026

Uh oh!

Zachdehooge commented Jan 11, 2026

Uh oh!

christolis commented Jan 20, 2026 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

christolis commented Jan 4, 2026 •

edited

Loading

christolis commented Jan 20, 2026 via email •

edited

Loading