Skip to content

fix(devtools): ignore the hotkey while focus is in an editable element #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kinbaum wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(devtools): ignore the hotkey while focus is in an editable element #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2126a
fix: ignore the hotkey while focus is in an editable element by guard…
Kinbaum Jan 17, 2026
183ad57
fix: enhance shortcut functionality by preventing activation in edita…
Kinbaum Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-donkeys-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/devtools': patch
---

Ignore the hotkey while focus is in an editable element by guarding the createShortcut callback
11 changes: 11 additions & 0 deletions packages/devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,21 @@ export default function DevTools() {
}
})
createEffect(() => {
const isEditableTarget = (element: Element | null) => {
if (!element || !(element instanceof HTMLElement)) return false
if (element.isContentEditable) return true
const tagName = element.tagName
if (tagName === 'INPUT' || tagName === 'TEXTAREA' || tagName === 'SELECT') {
return true
}
return element.getAttribute('role') === 'textbox'
}

const permutations = getHotkeyPermutations(settings().openHotkey)

for (const permutation of permutations) {
createShortcut(permutation, () => {
if (isEditableTarget(document.activeElement)) return
toggleOpen()
})
}
Expand Down